From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: binutils@sourceware.org
Cc: Siddhesh Poyarekar <siddhesh@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory
Date: Mon, 28 May 2012 21:29:00 -0000 [thread overview]
Message-ID: <20120528212920.GA27749@host2.jankratochvil.net> (raw)
In-Reply-To: <20120528110313.GH3086@bubble.grove.modra.org>
On Mon, 28 May 2012 13:03:13 +0200, Alan Modra wrote:
> Since Jan has already given the OK, and these functions are only used
> by gdb, binutils maintainers hardly need to look at the patch. OK
> anyway, but please fix the ChangeLog
I would like to make the function at least formally really working with the new
types, therefore the patch below.
OK from me for the gdb/ part.
Thanks,
Jan
bfd/
2012-05-28 Jan Kratochvil <jan.kratochvil@redhat.com>
* elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Make
contents_size type bfd_size_type.
diff --git a/bfd/elfcode.h b/bfd/elfcode.h
index c985c63..1ff3f07 100644
--- a/bfd/elfcode.h
+++ b/bfd/elfcode.h
@@ -1623,7 +1623,7 @@ NAME(_bfd_elf,bfd_from_remote_memory)
Elf_Internal_Phdr *i_phdrs, *last_phdr;
bfd *nbfd;
struct bfd_in_memory *bim;
- int contents_size;
+ bfd_size_type contents_size;
bfd_byte *contents;
int err;
unsigned int i;
next prev parent reply other threads:[~2012-05-28 21:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 9:05 Siddhesh Poyarekar
2012-05-28 11:03 ` Alan Modra
2012-05-28 11:11 ` Siddhesh Poyarekar
2012-05-28 21:29 ` Jan Kratochvil [this message]
2012-06-01 18:06 ` [commit bfd+gdb] " Jan Kratochvil
2012-06-01 18:24 ` Hans-Peter Nilsson
2012-06-01 19:54 ` Siddhesh Poyarekar
2012-06-01 20:31 ` Jan Kratochvil
2012-06-01 21:05 ` [patch#2] " Jan Kratochvil
2012-06-01 21:21 ` Hans-Peter Nilsson
2012-06-04 5:10 ` Hans-Peter Nilsson
2012-06-04 5:25 ` Jan Kratochvil
2012-06-04 6:23 ` Hans-Peter Nilsson
2012-06-04 12:11 ` Alan Modra
2012-06-04 14:37 ` [commit] " Jan Kratochvil
-- strict thread matches above, loose matches on Subject: below --
2012-05-28 9:04 [PATCH] " Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528212920.GA27749@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=siddhesh@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox