From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 450 invoked by alias); 28 May 2012 21:29:38 -0000 Received: (qmail 436 invoked by uid 22791); 28 May 2012 21:29:37 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 May 2012 21:29:25 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4SLTPf1030582 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 May 2012 17:29:25 -0400 Received: from host2.jankratochvil.net (ovpn-116-47.ams2.redhat.com [10.36.116.47]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4SLTLS3026854 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 28 May 2012 17:29:23 -0400 Date: Mon, 28 May 2012 21:29:00 -0000 From: Jan Kratochvil To: binutils@sourceware.org Cc: Siddhesh Poyarekar , gdb-patches@sourceware.org Subject: Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory Message-ID: <20120528212920.GA27749@host2.jankratochvil.net> References: <20120528143520.29254d79@spoyarek> <20120528110313.GH3086@bubble.grove.modra.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120528110313.GH3086@bubble.grove.modra.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg01007.txt.bz2 On Mon, 28 May 2012 13:03:13 +0200, Alan Modra wrote: > Since Jan has already given the OK, and these functions are only used > by gdb, binutils maintainers hardly need to look at the patch. OK > anyway, but please fix the ChangeLog I would like to make the function at least formally really working with the new types, therefore the patch below. OK from me for the gdb/ part. Thanks, Jan bfd/ 2012-05-28 Jan Kratochvil * elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Make contents_size type bfd_size_type. diff --git a/bfd/elfcode.h b/bfd/elfcode.h index c985c63..1ff3f07 100644 --- a/bfd/elfcode.h +++ b/bfd/elfcode.h @@ -1623,7 +1623,7 @@ NAME(_bfd_elf,bfd_from_remote_memory) Elf_Internal_Phdr *i_phdrs, *last_phdr; bfd *nbfd; struct bfd_in_memory *bim; - int contents_size; + bfd_size_type contents_size; bfd_byte *contents; int err; unsigned int i;