From: Siddhesh Poyarekar <siddhesh@redhat.com>
To: Alan Modra <amodra@gmail.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory
Date: Mon, 28 May 2012 11:11:00 -0000 [thread overview]
Message-ID: <20120528164122.5880e9f7@spoyarek> (raw)
In-Reply-To: <20120528110313.GH3086@bubble.grove.modra.org>
On Mon, 28 May 2012 20:33:13 +0930, Alan wrote:
> On Mon, May 28, 2012 at 02:35:20PM +0530, Siddhesh Poyarekar wrote:
> > 2012-05-28 Siddhesh Poyarekar <siddhesh@redhat.com>
> >
> > * bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN
> > argument of target_read_memory as size_t.
> > * bfd-in2.h: Regenerate.
> > * elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN
> > argument of target_read_memory as size_t.
> > (_bfd_elf32_bfd_from_remote_memory): Likewise.
> > (_bfd_elf64_bfd_from_remote_memory): Likewise.
> > * elf.c (bfd_elf_bfd_from_remote_memory): Likewise.
> > * enfcode.h (NAME): Likewise.
>
> Since Jan has already given the OK, and these functions are only used
> by gdb, binutils maintainers hardly need to look at the patch. OK
> anyway, but please fix the ChangeLog
>
> * elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise.
>
Thanks, fixed ChangeLog for bfd below as per your suggestion.
Regards,
Siddhesh
2012-05-28 Siddhesh Poyarekar <siddhesh@redhat.com>
* bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN argument
of target_read_memory as size_t.
* bfd-in2.h: Regenerate.
* elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN
argument of target_read_memory as size_t.
(_bfd_elf32_bfd_from_remote_memory): Likewise.
(_bfd_elf64_bfd_from_remote_memory): Likewise.
* elf.c (bfd_elf_bfd_from_remote_memory): Likewise.
* enfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise.
next prev parent reply other threads:[~2012-05-28 11:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 9:05 Siddhesh Poyarekar
2012-05-28 11:03 ` Alan Modra
2012-05-28 11:11 ` Siddhesh Poyarekar [this message]
2012-05-28 21:29 ` Jan Kratochvil
2012-06-01 18:06 ` [commit bfd+gdb] " Jan Kratochvil
2012-06-01 18:24 ` Hans-Peter Nilsson
2012-06-01 19:54 ` Siddhesh Poyarekar
2012-06-01 20:31 ` Jan Kratochvil
2012-06-01 21:05 ` [patch#2] " Jan Kratochvil
2012-06-01 21:21 ` Hans-Peter Nilsson
2012-06-04 5:10 ` Hans-Peter Nilsson
2012-06-04 5:25 ` Jan Kratochvil
2012-06-04 6:23 ` Hans-Peter Nilsson
2012-06-04 12:11 ` Alan Modra
2012-06-04 14:37 ` [commit] " Jan Kratochvil
-- strict thread matches above, loose matches on Subject: below --
2012-05-28 9:04 [PATCH] " Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120528164122.5880e9f7@spoyarek \
--to=siddhesh@redhat.com \
--cc=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox