From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2359 invoked by alias); 28 May 2012 11:11:15 -0000 Received: (qmail 2342 invoked by uid 22791); 28 May 2012 11:11:13 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,MAY_BE_FORGED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 28 May 2012 11:10:57 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4SBAucK009531 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 28 May 2012 07:10:56 -0400 Received: from spoyarek (dhcp233-8.pnq.redhat.com [10.65.223.8] (may be forged)) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4SBArnH012313; Mon, 28 May 2012 07:10:54 -0400 Date: Mon, 28 May 2012 11:11:00 -0000 From: Siddhesh Poyarekar To: Alan Modra Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory Message-ID: <20120528164122.5880e9f7@spoyarek> In-Reply-To: <20120528110313.GH3086@bubble.grove.modra.org> References: <20120528143520.29254d79@spoyarek> <20120528110313.GH3086@bubble.grove.modra.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00990.txt.bz2 On Mon, 28 May 2012 20:33:13 +0930, Alan wrote: > On Mon, May 28, 2012 at 02:35:20PM +0530, Siddhesh Poyarekar wrote: > > 2012-05-28 Siddhesh Poyarekar > > > > * bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN > > argument of target_read_memory as size_t. > > * bfd-in2.h: Regenerate. > > * elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN > > argument of target_read_memory as size_t. > > (_bfd_elf32_bfd_from_remote_memory): Likewise. > > (_bfd_elf64_bfd_from_remote_memory): Likewise. > > * elf.c (bfd_elf_bfd_from_remote_memory): Likewise. > > * enfcode.h (NAME): Likewise. > > Since Jan has already given the OK, and these functions are only used > by gdb, binutils maintainers hardly need to look at the patch. OK > anyway, but please fix the ChangeLog > > * elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise. > Thanks, fixed ChangeLog for bfd below as per your suggestion. Regards, Siddhesh 2012-05-28 Siddhesh Poyarekar * bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN argument of target_read_memory as size_t. * bfd-in2.h: Regenerate. * elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN argument of target_read_memory as size_t. (_bfd_elf32_bfd_from_remote_memory): Likewise. (_bfd_elf64_bfd_from_remote_memory): Likewise. * elf.c (bfd_elf_bfd_from_remote_memory): Likewise. * enfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise.