From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4985 invoked by alias); 4 Jun 2012 06:23:11 -0000 Received: (qmail 4965 invoked by uid 22791); 4 Jun 2012 06:23:10 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RCVD_IN_HOSTKARMA_NO,TW_YM,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from anubis.se.axis.com (HELO anubis.se.axis.com) (195.60.68.12) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 06:22:56 +0000 Received: from localhost (localhost [127.0.0.1]) by anubis.se.axis.com (Postfix) with ESMTP id 179FB19DC7; Mon, 4 Jun 2012 08:22:54 +0200 (CEST) Received: from anubis.se.axis.com ([127.0.0.1]) by localhost (anubis.se.axis.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HMClgxoDwEJj; Mon, 4 Jun 2012 08:22:53 +0200 (CEST) Received: from seth.se.axis.com (seth.se.axis.com [10.0.2.172]) by anubis.se.axis.com (Postfix) with ESMTP id 704BD19D88; Mon, 4 Jun 2012 08:22:53 +0200 (CEST) Received: from ignucius.se.axis.com (ignucius.se.axis.com [10.88.21.50]) by seth.se.axis.com (Postfix) with ESMTP id 61A493E0A9; Mon, 4 Jun 2012 08:22:53 +0200 (CEST) Received: from ignucius.se.axis.com (localhost [127.0.0.1]) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) with ESMTP id q546Mqmt026312; Mon, 4 Jun 2012 08:22:53 +0200 Received: (from hp@localhost) by ignucius.se.axis.com (8.12.8p1/8.12.8/Debian-2woody1) id q546Mqbu026308; Mon, 4 Jun 2012 08:22:52 +0200 Date: Mon, 04 Jun 2012 06:23:00 -0000 Message-Id: <201206040622.q546Mqbu026308@ignucius.se.axis.com> From: Hans-Peter Nilsson To: jan.kratochvil@redhat.com CC: siddhesh@redhat.com, binutils@sourceware.org, gdb-patches@sourceware.org In-reply-to: <20120604052438.GA19227@host2.jankratochvil.net> (message from Jan Kratochvil on Mon, 4 Jun 2012 07:24:38 +0200) Subject: Re: [patch#2] bfd: Use size_t for length argument totarget_read_memory function passed into bfd_elf_bfd_from_remote_memory MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-06/txt/msg00076.txt.bz2 > From: Jan Kratochvil > Date: Mon, 4 Jun 2012 07:24:38 +0200 > On Mon, 04 Jun 2012 07:10:18 +0200, Hans-Peter Nilsson wrote: > > > From: Jan Kratochvil > > > Date: Fri, 1 Jun 2012 23:05:30 +0200 > > > > > bfd/ > > > 2012-06-01 Jan Kratochvil > > > > > > * bfd-in.h (bfd_elf_bfd_from_remote_memory): Make LEN argument > > > of target_read_memory as bfd_size_type. > > > * bfd-in2.h: Regenerate. > > > * elf-bfd.h (elf_backend_bfd_from_remote_memory): Make LEN > > > argument of target_read_memory as size_t. > > (..."as bfd_size_type.") > > > > > (_bfd_elf32_bfd_from_remote_memory): Likewise. > > > (_bfd_elf64_bfd_from_remote_memory): Likewise. > > > * elf.c (bfd_elf_bfd_from_remote_memory): Likewise. > > > * elfcode.h (NAME(_bfd_elf,bfd_from_remote_memory)): Likewise. > > > > > > gdb/ > > > 2012-06-01 Jan Kratochvil > > > > > > * symfile-mem.c: 3 new gdb_static_assert for target_read_memory_bfd > > > parameters. > > > (target_read_memory_bfd): New function. > > > (symbol_file_add_from_memory): Use it. > > > > If this is ready to commit and you don't have the time today, > > just say the word. > > I believe I need bfd/ approval by Alan or other bfd/ maintainer. (I take it all necessary testing is done, then.) If it'd been me, I'd interpret Alan's: "since Jan has already given the OK, and these functions are only used by gdb, binutils maintainers hardly need to look at the patch" (regarding the earlier corresponding breaking change to size_t) as an intent of delegation of these bits, but that may be a bit wild. In the meantime, there's a broken tree. brgds, H-P