Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
Date: Fri, 27 Apr 2012 10:32:00 -0000	[thread overview]
Message-ID: <20120427101428.GB12423@mudshark.cambridge.arm.com> (raw)
In-Reply-To: <4F99A2F6.8050403@redhat.com>

On Thu, Apr 26, 2012 at 08:33:10PM +0100, Pedro Alves wrote:
> On 04/26/2012 07:03 PM, Will Deacon wrote:
> 
> > 2012-04-26  Will Deacon  <will.deacon@arm.com>
> > 
> > 	* linux-low.c: Pull in PT_TEXT_ADDR, PT_TEXT_END_ADDR and
> > 	PT_DATA_ADDR definitions from asm/ptrace.h.
> 
> 
> This needs tweaking to conform to the GNU Coding Standards.  Write as:
> 
> 	* linux-low.c [__UCLIBC__ && !(__UCLIBC_HAS_MMU__ || __ARCH_HAS_MMU__)]:
>         Include asm/ptrace.h.
> 	(PT_TEXT_ADDR, PT_DATA_ADDR, PT_TEXT_END_ADDR): Define only if not
> 	already defined.
> 
> Okay with this, and the formatting issues pointed out by Mike fixed.

Thanks Pedro, I'll post a v4 with the formatting changes today.

Will


      reply	other threads:[~2012-04-27 10:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 18:06 Will Deacon
2012-04-26 18:11 ` Pedro Alves
2012-04-26 18:15 ` Mike Frysinger
2012-04-26 18:23   ` Pedro Alves
2012-04-26 18:26     ` Mike Frysinger
2012-04-26 18:34       ` Pedro Alves
2012-04-26 18:36         ` Will Deacon
2012-04-26 18:53           ` Pedro Alves
2012-04-26 18:59             ` Pedro Alves
2012-04-26 19:06             ` Mike Frysinger
2012-04-26 19:26               ` Pedro Alves
2012-04-27  7:25                 ` Jan Kratochvil
2012-04-26 18:37   ` Will Deacon
2012-04-26 19:36 ` Pedro Alves
2012-04-27 10:32   ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120427101428.GB12423@mudshark.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox