From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-90443-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 15446 invoked by alias); 27 Apr 2012 10:14:49 -0000
Received: (qmail 15437 invoked by uid 22791); 27 Apr 2012 10:14:48 -0000
X-SWARE-Spam-Status: No, hits=-5.4 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Apr 2012 10:14:34 +0000
Received: from mudshark.cambridge.arm.com (mudshark.cambridge.arm.com [10.1.79.58])	by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id q3RAEUOK005161;	Fri, 27 Apr 2012 11:14:30 +0100 (BST)
Date: Fri, 27 Apr 2012 10:32:00 -0000
From: Will Deacon <will.deacon@arm.com>
To: Pedro Alves <palves@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
Message-ID: <20120427101428.GB12423@mudshark.cambridge.arm.com>
References: <1335463380-7288-1-git-send-email-will.deacon@arm.com> <4F99A2F6.8050403@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F99A2F6.8050403@redhat.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-04/txt/msg00978.txt.bz2

On Thu, Apr 26, 2012 at 08:33:10PM +0100, Pedro Alves wrote:
> On 04/26/2012 07:03 PM, Will Deacon wrote:
> 
> > 2012-04-26  Will Deacon  <will.deacon@arm.com>
> > 
> > 	* linux-low.c: Pull in PT_TEXT_ADDR, PT_TEXT_END_ADDR and
> > 	PT_DATA_ADDR definitions from asm/ptrace.h.
> 
> 
> This needs tweaking to conform to the GNU Coding Standards.  Write as:
> 
> 	* linux-low.c [__UCLIBC__ && !(__UCLIBC_HAS_MMU__ || __ARCH_HAS_MMU__)]:
>         Include asm/ptrace.h.
> 	(PT_TEXT_ADDR, PT_DATA_ADDR, PT_TEXT_END_ADDR): Define only if not
> 	already defined.
> 
> Okay with this, and the formatting issues pointed out by Mike fixed.

Thanks Pedro, I'll post a v4 with the formatting changes today.

Will