From: Mike Frysinger <vapier@gentoo.org>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org, Will Deacon <will.deacon@arm.com>
Subject: Re: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
Date: Thu, 26 Apr 2012 18:26:00 -0000 [thread overview]
Message-ID: <201204261427.46580.vapier@gentoo.org> (raw)
In-Reply-To: <4F9990A3.6030905@redhat.com>
[-- Attachment #1: Type: Text/Plain, Size: 1019 bytes --]
On Thursday 26 April 2012 14:14:59 Pedro Alves wrote:
> On 04/26/2012 07:12 PM, Mike Frysinger wrote:
> > On Thursday 26 April 2012 14:03:00 Will Deacon wrote:
> >> > +/* PTRACE_TEXT_ADDR and friends. */
> >> > +#include <asm/ptrace.h>
> >
> > check for asm/ptrace.h in configure.ac and then just depend on
> > HAVE_ASM_PTRACE_H ? although this is fine too since uClibc is
> > realistically the only C library being used with no-mmu Linux systems.
>
> Was there a time Linux didn't have this header? When we include it GDB, we
> include it unconditionally (though we don't include it in all ports), and
> in current mainline, it seems that all 27 ports under arch/ have it.
it's not so much a matter of whether it's provided, but whether it can be
safely included. ia64 has a history of being a pita to include their ptrace
headers, but maybe that doesn't matter to gdbserver.
might be worth seeing if we can do a release with an unconditional include and
see if anyone complains.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-26 18:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-26 18:06 Will Deacon
2012-04-26 18:11 ` Pedro Alves
2012-04-26 18:15 ` Mike Frysinger
2012-04-26 18:23 ` Pedro Alves
2012-04-26 18:26 ` Mike Frysinger [this message]
2012-04-26 18:34 ` Pedro Alves
2012-04-26 18:36 ` Will Deacon
2012-04-26 18:53 ` Pedro Alves
2012-04-26 18:59 ` Pedro Alves
2012-04-26 19:06 ` Mike Frysinger
2012-04-26 19:26 ` Pedro Alves
2012-04-27 7:25 ` Jan Kratochvil
2012-04-26 18:37 ` Will Deacon
2012-04-26 19:36 ` Pedro Alves
2012-04-27 10:32 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204261427.46580.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox