Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: gdb-patches@sourceware.org
Cc: palves@redhat.com, Will Deacon <will.deacon@arm.com>
Subject: [PATCH v3] gdbserver: uclinux: pull in ptrace offset definitions from asm/ptrace.h
Date: Thu, 26 Apr 2012 18:06:00 -0000	[thread overview]
Message-ID: <1335463380-7288-1-git-send-email-will.deacon@arm.com> (raw)

When debugging a uclinux target, it is necessary to retrieve the text
and data offsets of the running program in order for symbol resolution
to work correctly.

This patch pulls in definitions for PT_{TEXT,DATA,TEXT_END}_ADDR from
the kernel's exported ptrace header, which can be issued as `magic'
addresses to the PTRACE_PEEKUSER request in order to retrieve the child
offsets. For those architectures currently providing their own inline
definitions, the existing code is used as a fallback if the header
doesn't provide any overrides.
---

2012-04-26  Will Deacon  <will.deacon@arm.com>

	* linux-low.c: Pull in PT_TEXT_ADDR, PT_TEXT_END_ADDR and
	PT_DATA_ADDR definitions from asm/ptrace.h.

 gdb/gdbserver/linux-low.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/gdb/gdbserver/linux-low.c b/gdb/gdbserver/linux-low.c
index bbb0693..0d1cbd0 100644
--- a/gdb/gdbserver/linux-low.c
+++ b/gdb/gdbserver/linux-low.c
@@ -78,6 +78,8 @@
 
 #ifdef __UCLIBC__
 #if !(defined(__UCLIBC_HAS_MMU__) || defined(__ARCH_HAS_MMU__))
+/* PTRACE_TEXT_ADDR and friends.  */
+#include <asm/ptrace.h>
 #define HAS_NOMMU
 #endif
 #endif
@@ -4759,6 +4761,9 @@ linux_stopped_data_address (void)
 }
 
 #if defined(__UCLIBC__) && defined(HAS_NOMMU)
+#if !(defined(PT_TEXT_ADDR) || \
+      defined(PT_DATA_ADDR) || \
+      defined(PT_TEXT_END_ADDR))
 #if defined(__mcoldfire__)
 /* These should really be defined in the kernel's ptrace.h header.  */
 #define PT_TEXT_ADDR 49*4
@@ -4773,6 +4778,7 @@ linux_stopped_data_address (void)
 #define PT_DATA_ADDR     (0x10004*4)
 #define PT_TEXT_END_ADDR (0x10008*4)
 #endif
+#endif
 
 /* Under uClinux, programs are loaded at non-zero offsets, which we need
    to tell gdb about.  */
-- 
1.7.4.1


             reply	other threads:[~2012-04-26 18:03 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-26 18:06 Will Deacon [this message]
2012-04-26 18:11 ` Pedro Alves
2012-04-26 18:15 ` Mike Frysinger
2012-04-26 18:23   ` Pedro Alves
2012-04-26 18:26     ` Mike Frysinger
2012-04-26 18:34       ` Pedro Alves
2012-04-26 18:36         ` Will Deacon
2012-04-26 18:53           ` Pedro Alves
2012-04-26 18:59             ` Pedro Alves
2012-04-26 19:06             ` Mike Frysinger
2012-04-26 19:26               ` Pedro Alves
2012-04-27  7:25                 ` Jan Kratochvil
2012-04-26 18:37   ` Will Deacon
2012-04-26 19:36 ` Pedro Alves
2012-04-27 10:32   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335463380-7288-1-git-send-email-will.deacon@arm.com \
    --to=will.deacon@arm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox