From: Joel Brobecker <brobecker@adacore.com>
To: gdb-patches@sourceware.org
Subject: Re: [RFA/commit 2/2] pspace != NULL failed assertion on ppc-aix
Date: Wed, 18 Apr 2012 00:43:00 -0000 [thread overview]
Message-ID: <20120418003126.GV2852@adacore.com> (raw)
In-Reply-To: <1334610821-10974-3-git-send-email-brobecker@adacore.com>
> gdb/ChangeLog:
>
> * xcoffread.c (xcoff_secnum_to_sections): New function.
> (secnum_to_section, secnum_to_bfd_section): Reimplement
> using xcoff_secnum_to_sections. Rename "secnum" parameter
> into "n_scnum".
> (RECORD_MINIMAL_SYMBOL): Delete.
> (record_minimal_symbol): New function.
> (scan_xcoff_symtab): Replace uses of RECORD_MINIMAL_SYMBOL
> by call to record_minimal_symbol and set misc_func_recorded
> to 1. Set last_csect_sec to the XCOFF section index instead
> of GDB's section_offset index. Update calls to
> prim_record_minimal_symbol_and_info to pass the BFD section
> as well.
Unfortunately, as explained at
http://www.sourceware.org/ml/gdb-patches/2012-04/msg00523.html, I was
not able to test this patch against the official testsuite. I think
it's an expect problem on AIX, and I did take the time a long time
to look into the expect sources, and fix some of the problems I faced
at the time. But I don't want to do that again, not for AIX.
As far as I am concerned, I am satisfied with just running the
AdaCore testsuite, where it shows no regression, and I think it
is an overall improvement as well. I don't know if anyone else really
cares about that port? In the meantime, I have checked the patch in.
It's easy to revert if there are objections.
--
Joel
next prev parent reply other threads:[~2012-04-18 0:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 21:14 RFC: bfd_section should not be NULL in call to prim_record_minimal_* Joel Brobecker
2012-04-16 21:14 ` [RFA/commit 1/2] Unused local variables in xcoffread.c:read_xcoff_symtab Joel Brobecker
2012-04-16 21:19 ` [RFA/commit 2/2] pspace != NULL failed assertion on ppc-aix Joel Brobecker
2012-04-18 0:43 ` Joel Brobecker [this message]
2012-04-18 10:17 ` Pedro Alves
2012-04-18 14:57 ` Joel Brobecker
2012-04-18 15:13 ` Pedro Alves
2012-04-18 0:32 ` checked in: [RFA/commit 1/2] Unused local variables in xcoffread.c:read_xcoff_symtab Joel Brobecker
2012-04-17 12:03 ` RFC: bfd_section should not be NULL in call to prim_record_minimal_* Tom Tromey
2012-04-17 15:17 ` Joel Brobecker
2012-04-17 15:23 ` Tom Tromey
2012-04-17 23:26 ` Joel Brobecker
2012-04-18 15:01 ` Tom Tromey
2012-04-18 0:24 ` Joel Brobecker
2012-04-17 12:45 ` Pedro Alves
2012-04-17 14:21 ` Tom Tromey
2012-04-17 14:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418003126.GV2852@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox