From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1009 invoked by alias); 18 Apr 2012 00:32:13 -0000 Received: (qmail 1000 invoked by uid 22791); 18 Apr 2012 00:32:12 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 00:31:35 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id C49B81C6C31 for ; Tue, 17 Apr 2012 20:31:34 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id e8j4BT+49hHG for ; Tue, 17 Apr 2012 20:31:34 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 88CA91C6C2F for ; Tue, 17 Apr 2012 20:31:34 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 9C1F6145616; Tue, 17 Apr 2012 17:31:26 -0700 (PDT) Date: Wed, 18 Apr 2012 00:43:00 -0000 From: Joel Brobecker To: gdb-patches@sourceware.org Subject: Re: [RFA/commit 2/2] pspace != NULL failed assertion on ppc-aix Message-ID: <20120418003126.GV2852@adacore.com> References: <1334610821-10974-1-git-send-email-brobecker@adacore.com> <1334610821-10974-2-git-send-email-brobecker@adacore.com> <1334610821-10974-3-git-send-email-brobecker@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1334610821-10974-3-git-send-email-brobecker@adacore.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00529.txt.bz2 > gdb/ChangeLog: > > * xcoffread.c (xcoff_secnum_to_sections): New function. > (secnum_to_section, secnum_to_bfd_section): Reimplement > using xcoff_secnum_to_sections. Rename "secnum" parameter > into "n_scnum". > (RECORD_MINIMAL_SYMBOL): Delete. > (record_minimal_symbol): New function. > (scan_xcoff_symtab): Replace uses of RECORD_MINIMAL_SYMBOL > by call to record_minimal_symbol and set misc_func_recorded > to 1. Set last_csect_sec to the XCOFF section index instead > of GDB's section_offset index. Update calls to > prim_record_minimal_symbol_and_info to pass the BFD section > as well. Unfortunately, as explained at http://www.sourceware.org/ml/gdb-patches/2012-04/msg00523.html, I was not able to test this patch against the official testsuite. I think it's an expect problem on AIX, and I did take the time a long time to look into the expect sources, and fix some of the problems I faced at the time. But I don't want to do that again, not for AIX. As far as I am concerned, I am satisfied with just running the AdaCore testsuite, where it shows no regression, and I think it is an overall improvement as well. I don't know if anyone else really cares about that port? In the meantime, I have checked the patch in. It's easy to revert if there are objections. -- Joel