From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: bfd_section should not be NULL in call to prim_record_minimal_*
Date: Tue, 17 Apr 2012 15:17:00 -0000 [thread overview]
Message-ID: <20120417151549.GN2852@adacore.com> (raw)
In-Reply-To: <87zkaawp9g.fsf@fleche.redhat.com>
> This change is fine with me -- even more than fine, I think removing
> special cases is generally better when possible.
Thanks. I will commit this change today.
> However, if this is just a regression caused by linespec changes, maybe
> it can also be fixed in another way. That is, you can find a minsym's
> objfile using msymbol_objfile; I think this would fix the possibly
> problematic uses I see in linespec.c (the one in minsym_found is maybe
> ok).
Yes, I agree. I read the entire thread, and it seems so simple to
fix the problem that way as well. I think both approaches should
be applied.
> Did you audit the other symbol readers?
Hmmm, no. Wildo.
--
Joel
next prev parent reply other threads:[~2012-04-17 15:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 21:14 Joel Brobecker
2012-04-16 21:14 ` [RFA/commit 1/2] Unused local variables in xcoffread.c:read_xcoff_symtab Joel Brobecker
2012-04-16 21:19 ` [RFA/commit 2/2] pspace != NULL failed assertion on ppc-aix Joel Brobecker
2012-04-18 0:43 ` Joel Brobecker
2012-04-18 10:17 ` Pedro Alves
2012-04-18 14:57 ` Joel Brobecker
2012-04-18 15:13 ` Pedro Alves
2012-04-18 0:32 ` checked in: [RFA/commit 1/2] Unused local variables in xcoffread.c:read_xcoff_symtab Joel Brobecker
2012-04-17 12:03 ` RFC: bfd_section should not be NULL in call to prim_record_minimal_* Tom Tromey
2012-04-17 15:17 ` Joel Brobecker [this message]
2012-04-17 15:23 ` Tom Tromey
2012-04-17 23:26 ` Joel Brobecker
2012-04-18 15:01 ` Tom Tromey
2012-04-18 0:24 ` Joel Brobecker
2012-04-17 12:45 ` Pedro Alves
2012-04-17 14:21 ` Tom Tromey
2012-04-17 14:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417151549.GN2852@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox