From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: bfd_section should not be NULL in call to prim_record_minimal_*
Date: Tue, 17 Apr 2012 23:26:00 -0000 [thread overview]
Message-ID: <20120417231206.GQ2852@adacore.com> (raw)
In-Reply-To: <87obqqv13b.fsf@fleche.redhat.com>
> Could you test my patch, applied to an unpatched gdb, on AIX?
> If it works for you I will write a ChangeLog entry and check it in.
> I don't have a good way to test it here AFAIK.
Of course! I will explain this again next to the other AIX patches,
but I wasn't able to run the entire testsuite on AIX. After printing
the results of the first group of testcases, expect just hangs, and
the terminal also appears to be unrecoverably frozen. I've tried
killing the expect processes without luck, and I can't see any
runtest script running either, so my guess is that we're screwed.
So I tested your patch using AdaCore's testsuite, which shows that
it fixes the problem as well, with no unexpected failures. And since
this patch affects all platforms, I also tested it against the
official testsuite on x86_64-linux. No regression either.
So I think your patch is good to go.
--
Joel
next prev parent reply other threads:[~2012-04-17 23:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 21:14 Joel Brobecker
2012-04-16 21:14 ` [RFA/commit 1/2] Unused local variables in xcoffread.c:read_xcoff_symtab Joel Brobecker
2012-04-16 21:19 ` [RFA/commit 2/2] pspace != NULL failed assertion on ppc-aix Joel Brobecker
2012-04-18 0:43 ` Joel Brobecker
2012-04-18 10:17 ` Pedro Alves
2012-04-18 14:57 ` Joel Brobecker
2012-04-18 15:13 ` Pedro Alves
2012-04-18 0:32 ` checked in: [RFA/commit 1/2] Unused local variables in xcoffread.c:read_xcoff_symtab Joel Brobecker
2012-04-17 12:03 ` RFC: bfd_section should not be NULL in call to prim_record_minimal_* Tom Tromey
2012-04-17 15:17 ` Joel Brobecker
2012-04-17 15:23 ` Tom Tromey
2012-04-17 23:26 ` Joel Brobecker [this message]
2012-04-18 15:01 ` Tom Tromey
2012-04-18 0:24 ` Joel Brobecker
2012-04-17 12:45 ` Pedro Alves
2012-04-17 14:21 ` Tom Tromey
2012-04-17 14:29 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417231206.GQ2852@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox