From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11318 invoked by alias); 17 Apr 2012 23:12:30 -0000 Received: (qmail 11305 invoked by uid 22791); 17 Apr 2012 23:12:28 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 17 Apr 2012 23:12:15 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 012221C6C3B; Tue, 17 Apr 2012 19:12:15 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1e4U8erhBNz4; Tue, 17 Apr 2012 19:12:14 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id C4A1B1C6C38; Tue, 17 Apr 2012 19:12:14 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id F0DF6145616; Tue, 17 Apr 2012 16:12:06 -0700 (PDT) Date: Tue, 17 Apr 2012 23:26:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFC: bfd_section should not be NULL in call to prim_record_minimal_* Message-ID: <20120417231206.GQ2852@adacore.com> References: <1334610821-10974-1-git-send-email-brobecker@adacore.com> <87zkaawp9g.fsf@fleche.redhat.com> <20120417151549.GN2852@adacore.com> <87obqqv13b.fsf@fleche.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87obqqv13b.fsf@fleche.redhat.com> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00524.txt.bz2 > Could you test my patch, applied to an unpatched gdb, on AIX? > If it works for you I will write a ChangeLog entry and check it in. > I don't have a good way to test it here AFAIK. Of course! I will explain this again next to the other AIX patches, but I wasn't able to run the entire testsuite on AIX. After printing the results of the first group of testcases, expect just hangs, and the terminal also appears to be unrecoverably frozen. I've tried killing the expect processes without luck, and I can't see any runtest script running either, so my guess is that we're screwed. So I tested your patch using AdaCore's testsuite, which shows that it fixes the problem as well, with no unexpected failures. And since this patch affects all platforms, I also tested it against the official testsuite on x86_64-linux. No regression either. So I think your patch is good to go. -- Joel