Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE
Date: Mon, 16 Apr 2012 14:56:00 -0000	[thread overview]
Message-ID: <20120416144401.GI2852@adacore.com> (raw)
In-Reply-To: <CAGyQ6gz-OsHGi2WefE=x9Z+02fegrcfAcJVPo4bL+TJ8BbxAhw@mail.gmail.com>

Hello Siva,

> 2012-04-16  Siva Chandra Reddy  <sivachandra@google.com>
> 
>         * CONTRIBUTE: Add "cvs diff -up" as a way to generate patches
>         when accessing the CVS repository.  Add a note saying that the
>         "-up" flavors of "cvs diff" and "diff" are preferred.

Thanks for doing that.

Personally, I'd even get rid of the "diff -cp" alternative. We'll
continue accepting context diffs, but I think that suggesting it,
even if we say later on that we prefer unified diffs, will result
in more patches sent in that format.  If we do not want to remove
the context diff alternative, then at least let's put it second.

What do others think?

-- 
Joel


  reply	other threads:[~2012-04-16 14:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  7:50 Siva Chandra
2012-04-16 14:56 ` Joel Brobecker [this message]
2012-04-16 15:07   ` Pedro Alves
2012-04-17  7:26     ` Siva Chandra
2012-04-17 15:11       ` Joel Brobecker
2012-04-17 15:48         ` Mark Kettenis
2012-04-24  7:10         ` Siva Chandra
2012-04-24 17:39           ` Eli Zaretskii
2012-04-24 20:24             ` Joel Brobecker
2012-04-25  5:47               ` Eli Zaretskii
2012-04-25  8:06                 ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416144401.GI2852@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox