Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE

Pedro Alves
2012-04-16T15:03:46Z

On 04/16/2012 03:44 PM, Joel Brobecker wrote:

> Hello Siva,
>
>> 2012-04-16 Siva Chandra Reddy <sivachandra@google.com>
>>
>> * CONTRIBUTE: Add "cvs diff -up" as a way to generate patches
>> when accessing the CVS repository. Add a note saying that the
>> "-up" flavors of "cvs diff" and "diff" are preferred.
>
> Thanks for doing that.
>
> Personally, I'd even get rid of the "diff -cp" alternative. We'll
> continue accepting context diffs, but I think that suggesting it,
> even if we say later on that we prefer unified diffs, will result
> in more patches sent in that format.

Completely agreed. /me pokes at Stan. :-)

> If we do not want to remove
> the context diff alternative, then at least let's put it second.
>
> What do others think?

--
Pedro Alves