Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE

Siva Chandra
2012-04-24T06:57:57Z

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

On Tue, Apr 17, 2012 at 8:24 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> I also think that 2 GMs agreeing to remove "diff -cp" is enough
> to proceed, but I can take care of removing this part once your
> patch is in. I don't want you to keep flip-flopping just because
> of me.

Since I have not heard from Eli yet, I have gone ahead and removed the
context diff flavor.

2012-04-24 Siva Chandra Reddy <sivachandra@google.com>

* CONTRIBUTE: Use unified diff instead of context diff when
generating patches.

[-- Attachment #2: contribute_patch_v3.txt --]
[-- Type: text/plain, Size: 883 bytes --]

Index: CONTRIBUTE
===================================================================
RCS file: /cvs/src/src/gdb/CONTRIBUTE,v
retrieving revision 1.12
diff -u -p -r1.12 CONTRIBUTE
--- CONTRIBUTE 22 Aug 2009 17:08:09 -0000 1.12
+++ CONTRIBUTE 24 Apr 2012 06:42:34 -0000
@@ -71,9 +71,9 @@ o Submitting Patches
documentation (i.e., .texi files).

The patch itself. If you are accessing the CVS repository use
- "cvs update; cvs diff -cp"; else, use "diff -cp OLD NEW" or
- "diff -up OLD NEW". If your version of diff does not support
- these options, then get the latest version of GNU diff.
+ "cvs update; cvs diff -up"; else, use "diff -up OLD NEW". If
+ your version of diff does not support these options, then get
+ the latest version of GNU diff.

We accept patches as plain text (preferred for the compilers
themselves), MIME attachments (preferred for the web pages),