From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26257 invoked by alias); 16 Apr 2012 14:44:22 -0000 Received: (qmail 26249 invoked by uid 22791); 16 Apr 2012 14:44:21 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_NO X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 16 Apr 2012 14:44:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id BBC441C60D7; Mon, 16 Apr 2012 10:44:07 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id Li5fEe0WyYUH; Mon, 16 Apr 2012 10:44:07 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 895BA1C6072; Mon, 16 Apr 2012 10:44:07 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id D8C52145616; Mon, 16 Apr 2012 07:44:01 -0700 (PDT) Date: Mon, 16 Apr 2012 14:56:00 -0000 From: Joel Brobecker To: Siva Chandra Cc: gdb-patches@sourceware.org Subject: Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE Message-ID: <20120416144401.GI2852@adacore.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-04/txt/msg00416.txt.bz2 Hello Siva, > 2012-04-16 Siva Chandra Reddy > > * CONTRIBUTE: Add "cvs diff -up" as a way to generate patches > when accessing the CVS repository. Add a note saying that the > "-up" flavors of "cvs diff" and "diff" are preferred. Thanks for doing that. Personally, I'd even get rid of the "diff -cp" alternative. We'll continue accepting context diffs, but I think that suggesting it, even if we say later on that we prefer unified diffs, will result in more patches sent in that format. If we do not want to remove the context diff alternative, then at least let's put it second. What do others think? -- Joel