Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Siva Chandra <sivachandra@google.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <palves@redhat.com>,
	gdb-patches@sourceware.org, 	Eli Zaretskii <eliz@gnu.org>
Subject: Re: [RFA] - Improve suggestions for generating patches in CONTRIBUTE
Date: Tue, 24 Apr 2012 07:10:00 -0000	[thread overview]
Message-ID: <CAGyQ6gy2ZMxFxF75OPgHE-_hc3RbLtUV5wiTzrd97oEzp512HA@mail.gmail.com> (raw)
In-Reply-To: <20120417145452.GL2852@adacore.com>

[-- Attachment #1: Type: text/plain, Size: 535 bytes --]

On Tue, Apr 17, 2012 at 8:24 PM, Joel Brobecker <brobecker@adacore.com> wrote:
> I also think that 2 GMs agreeing to remove "diff -cp" is enough
> to proceed, but I can take care of removing this part once your
> patch is in. I don't want you to keep flip-flopping just because
> of me.

Since I have not heard from Eli yet, I have gone ahead and removed the
context diff flavor.

2012-04-24  Siva Chandra Reddy  <sivachandra@google.com>

        * CONTRIBUTE: Use unified diff instead of context diff when
        generating patches.

[-- Attachment #2: contribute_patch_v3.txt --]
[-- Type: text/plain, Size: 883 bytes --]

Index: CONTRIBUTE
===================================================================
RCS file: /cvs/src/src/gdb/CONTRIBUTE,v
retrieving revision 1.12
diff -u -p -r1.12 CONTRIBUTE
--- CONTRIBUTE	22 Aug 2009 17:08:09 -0000	1.12
+++ CONTRIBUTE	24 Apr 2012 06:42:34 -0000
@@ -71,9 +71,9 @@ o	Submitting Patches
 	documentation (i.e., .texi files).
 
 	The patch itself. If you are accessing the CVS repository use
-	"cvs update; cvs diff -cp"; else, use "diff -cp OLD NEW" or
-	"diff -up OLD NEW". If your version of diff does not support
-	these options, then get the latest version of GNU diff.
+	"cvs update; cvs diff -up"; else, use "diff -up OLD NEW". If
+	your version of diff does not support these options, then get
+	the latest version of GNU diff.
 
 	We accept patches as plain text (preferred for the compilers
 	themselves), MIME attachments (preferred for the web pages),

  parent reply	other threads:[~2012-04-24  6:57 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16  7:50 Siva Chandra
2012-04-16 14:56 ` Joel Brobecker
2012-04-16 15:07   ` Pedro Alves
2012-04-17  7:26     ` Siva Chandra
2012-04-17 15:11       ` Joel Brobecker
2012-04-17 15:48         ` Mark Kettenis
2012-04-24  7:10         ` Siva Chandra [this message]
2012-04-24 17:39           ` Eli Zaretskii
2012-04-24 20:24             ` Joel Brobecker
2012-04-25  5:47               ` Eli Zaretskii
2012-04-25  8:06                 ` Siva Chandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGyQ6gy2ZMxFxF75OPgHE-_hc3RbLtUV5wiTzrd97oEzp512HA@mail.gmail.com \
    --to=sivachandra@google.com \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox