From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: "Gustavo, Luis" <luis_gustavo@mentor.com>, gdb-patches@sourceware.org
Subject: [commit] [patch] update_global_location_list my comment fix [Re: [PATCH] Fix breakpoint updates for multi-inferior]
Date: Thu, 09 Feb 2012 08:21:00 -0000 [thread overview]
Message-ID: <20120209082045.GA10358@host2.jankratochvil.net> (raw)
In-Reply-To: <20120208172728.GA6951@host2.jankratochvil.net>
http://sourceware.org/ml/gdb-cvs/2012-02/msg00048.html
--- src/gdb/ChangeLog 2012/02/08 19:54:35 1.13816
+++ src/gdb/ChangeLog 2012/02/09 08:20:03 1.13817
@@ -1,3 +1,7 @@
+2012-02-09 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * breakpoint.c (bp_location_compare): Fix comment. Reindent the code.
+
2012-02-08 Joel Brobecker <brobecker@adacore.com>
* language.h (symbol_name_cmp_ftype): Renames
--- src/gdb/breakpoint.c 2012/02/02 20:19:12 1.650
+++ src/gdb/breakpoint.c 2012/02/09 08:20:03 1.651
@@ -10589,12 +10589,13 @@
if (a_perm != b_perm)
return (a_perm < b_perm) - (a_perm > b_perm);
- /* Make the user-visible order stable across GDB runs. Locations of
- the same breakpoint can be sorted in arbitrary order. */
+ /* Make the internal GDB representation stable across GDB runs
+ where A and B memory inside GDB can differ. Breakpoint locations of
+ the same type at the same address can be sorted in arbitrary order. */
if (a->owner->number != b->owner->number)
- return (a->owner->number > b->owner->number)
- - (a->owner->number < b->owner->number);
+ return ((a->owner->number > b->owner->number)
+ - (a->owner->number < b->owner->number));
return (a > b) - (a < b);
}
prev parent reply other threads:[~2012-02-09 8:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 21:27 [PATCH] Fix breakpoint updates for multi-inferior Luis Gustavo
2012-02-07 23:44 ` Luis Gustavo
2012-02-08 15:17 ` Pedro Alves
2012-02-08 15:27 ` Luis Gustavo
2012-02-08 15:47 ` Pedro Alves
2012-02-08 17:28 ` [patch] update_global_location_list my comment fix [Re: [PATCH] Fix breakpoint updates for multi-inferior] Jan Kratochvil
2012-02-08 23:19 ` Luis Gustavo
2012-02-08 23:32 ` Joel Brobecker
2012-02-08 23:40 ` Luis Gustavo
2012-02-09 8:23 ` Jan Kratochvil
2012-02-09 11:05 ` Luis Gustavo
2012-02-09 11:32 ` Pedro Alves
2012-02-24 15:24 ` Luis Gustavo
2012-02-09 8:21 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209082045.GA10358@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis_gustavo@mentor.com \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox