From: Pedro Alves <palves@redhat.com>
To: "Gustavo, Luis" <luis_gustavo@mentor.com>
Cc: gdb-patches@sourceware.org, Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [PATCH] Fix breakpoint updates for multi-inferior
Date: Wed, 08 Feb 2012 15:47:00 -0000 [thread overview]
Message-ID: <4F32990B.7060203@redhat.com> (raw)
In-Reply-To: <4F329468.3020307@mentor.com>
On 02/08/2012 03:27 PM, Luis Gustavo wrote:
>> Your change makes gdb loop over all locations once for each program space.
>> How about we sort by program space in addition to address in the first place, so
>> that we'd have:
>>
>> #1 PSPACE1 ADDR1
>> #2 PSPACE1 ADDR1
>> #3 PSPACE2 ADDR1
>>
>> and things would then still work correctly with just one pass?
>>
>
> breakpoint.c:bp_location_compare (...)'s comment about keeping a stable user-visible ordering of breakpoints made me consider that solution inappropriate.
>
> Maybe i'm missing something?
We're already sorting by address first, so I'm not really sure what is
it that's user-visible that we're trying to preserve. Jan? Even if that
is still necessary, would it be ok to sort by address, then pspace, and only
after by bkpt number?
--
Pedro Alves
next prev parent reply other threads:[~2012-02-08 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 21:27 Luis Gustavo
2012-02-07 23:44 ` Luis Gustavo
2012-02-08 15:17 ` Pedro Alves
2012-02-08 15:27 ` Luis Gustavo
2012-02-08 15:47 ` Pedro Alves [this message]
2012-02-08 17:28 ` [patch] update_global_location_list my comment fix [Re: [PATCH] Fix breakpoint updates for multi-inferior] Jan Kratochvil
2012-02-08 23:19 ` Luis Gustavo
2012-02-08 23:32 ` Joel Brobecker
2012-02-08 23:40 ` Luis Gustavo
2012-02-09 8:23 ` Jan Kratochvil
2012-02-09 11:05 ` Luis Gustavo
2012-02-09 11:32 ` Pedro Alves
2012-02-24 15:24 ` Luis Gustavo
2012-02-09 8:21 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F32990B.7060203@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=luis_gustavo@mentor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox