From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24823 invoked by alias); 9 Feb 2012 08:21:09 -0000 Received: (qmail 24812 invoked by uid 22791); 9 Feb 2012 08:21:07 -0000 X-SWARE-Spam-Status: No, hits=-6.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 09 Feb 2012 08:20:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q198KoNW026525 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Feb 2012 03:20:50 -0500 Received: from host2.jankratochvil.net (ovpn-116-26.ams2.redhat.com [10.36.116.26]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q198Kk4f017369 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 9 Feb 2012 03:20:49 -0500 Date: Thu, 09 Feb 2012 08:21:00 -0000 From: Jan Kratochvil To: Pedro Alves Cc: "Gustavo, Luis" , gdb-patches@sourceware.org Subject: [commit] [patch] update_global_location_list my comment fix [Re: [PATCH] Fix breakpoint updates for multi-inferior] Message-ID: <20120209082045.GA10358@host2.jankratochvil.net> References: <4F20610B.5010403@mentor.com> <4F3291D9.80705@redhat.com> <4F329468.3020307@mentor.com> <4F32990B.7060203@redhat.com> <20120208172728.GA6951@host2.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20120208172728.GA6951@host2.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00132.txt.bz2 http://sourceware.org/ml/gdb-cvs/2012-02/msg00048.html --- src/gdb/ChangeLog 2012/02/08 19:54:35 1.13816 +++ src/gdb/ChangeLog 2012/02/09 08:20:03 1.13817 @@ -1,3 +1,7 @@ +2012-02-09 Jan Kratochvil + + * breakpoint.c (bp_location_compare): Fix comment. Reindent the code. + 2012-02-08 Joel Brobecker * language.h (symbol_name_cmp_ftype): Renames --- src/gdb/breakpoint.c 2012/02/02 20:19:12 1.650 +++ src/gdb/breakpoint.c 2012/02/09 08:20:03 1.651 @@ -10589,12 +10589,13 @@ if (a_perm != b_perm) return (a_perm < b_perm) - (a_perm > b_perm); - /* Make the user-visible order stable across GDB runs. Locations of - the same breakpoint can be sorted in arbitrary order. */ + /* Make the internal GDB representation stable across GDB runs + where A and B memory inside GDB can differ. Breakpoint locations of + the same type at the same address can be sorted in arbitrary order. */ if (a->owner->number != b->owner->number) - return (a->owner->number > b->owner->number) - - (a->owner->number < b->owner->number); + return ((a->owner->number > b->owner->number) + - (a->owner->number < b->owner->number)); return (a > b) - (a < b); }