From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: Eli Zaretskii <eliz@gnu.org>,
jan.kratochvil@redhat.com, dje@google.com,
gdb-patches@sourceware.org
Subject: Re: [patch] New set auto-load-local-gdbinit + disable it by default
Date: Wed, 18 Jan 2012 04:26:00 -0000 [thread overview]
Message-ID: <20120118035927.GY31383@adacore.com> (raw)
In-Reply-To: <m3ty3uf2ww.fsf@fleche.redhat.com>
It's become really hard, at least for me, to focus on this discussion.
We started from discussing about the local .gdbinit file to everything
auto-loaded is unsafe. I see why the latter was discussed, and how it
was useful, so this is not a criticism.
After having read everyone's emails so far, my stance on this is:
. About reading the .gdbinit file in the current directory:
It's a question of how seriously the security weakness should be
taken. I confess I have a hard time taking them seriously, but
I know I am probably too naive. This is a feature that I could
personally live without, and therefore will not oppose its removal.
I would like to propose the following, however, to help the users
who want to continue relying on it. I am happy to implement it
if necessary:
Provide a new command that would read the .gdbinit file in
the current working directory if present, and do nothing
otherwise. I would like to provide options that select
between loading silently, and loading with a warning first,
and why not, asking before loading.
The idea is that the user who would like to preserve
the old behavior can put that command in his $HOME/.gdbinit
file.
. To me, it is extremely important that system-gdbinit is still
automatically loaded. The system gdbinit file is there to help
the user setup his debugging session. It should be considered
as trusted, and I oppose a change that would stop is automatic
loading. The language is strong, but it does not mean that
I have veto right - so if I am outvoted, so be it.
. About the auto-loading of Python code: I think that the cost
of removing the auto-loading, even if it is only for non-trusted
directories, would be too high. I would prefer if it discussed
this separately after the .gdbinit issue has been resolved.
--
Joel
next prev parent reply other threads:[~2012-01-18 4:00 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-17 10:16 Jan Kratochvil
2012-01-17 12:34 ` Eli Zaretskii
2012-01-17 13:42 ` Joel Brobecker
2012-01-17 14:49 ` [patch 7.4] Deprecate local .gdbinit [Re: [patch] New set auto-load-local-gdbinit + disable it by default] Jan Kratochvil
2012-01-17 16:22 ` Doug Evans
2012-01-17 20:22 ` [patch] New set auto-load-local-gdbinit + disable it by default Tom Tromey
2012-01-17 16:15 ` Doug Evans
2012-01-17 16:34 ` Jan Kratochvil
2012-01-17 16:48 ` Doug Evans
2012-01-17 17:27 ` Jan Kratochvil
2012-01-17 17:33 ` Doug Evans
2012-01-17 17:55 ` Jan Kratochvil
2012-01-17 18:29 ` Eli Zaretskii
2012-01-17 18:35 ` Jan Kratochvil
2012-01-17 19:54 ` Tom Tromey
2012-01-17 18:31 ` Doug Evans
2012-01-17 18:44 ` Jan Kratochvil
2012-01-17 19:12 ` Doug Evans
2012-01-17 19:20 ` Jan Kratochvil
2012-01-17 19:55 ` Tom Tromey
2012-01-17 20:24 ` Pedro Alves
2012-01-17 20:26 ` Tom Tromey
2012-01-17 20:35 ` Jan Kratochvil
2012-01-17 20:56 ` Pedro Alves
2012-01-17 19:30 ` Matt Rice
2012-01-17 19:37 ` Jan Kratochvil
2012-01-17 20:26 ` Tom Tromey
2012-01-17 18:00 ` Eli Zaretskii
2012-01-17 18:28 ` Jan Kratochvil
2012-01-17 18:43 ` Eli Zaretskii
2012-01-17 19:02 ` Jan Kratochvil
2012-01-17 20:29 ` Tom Tromey
2012-01-17 20:49 ` Jan Kratochvil
2012-01-17 20:54 ` Doug Evans
2012-01-17 21:10 ` Tom Tromey
2012-01-17 21:13 ` Eli Zaretskii
2012-01-17 21:14 ` Tom Tromey
2012-01-18 4:26 ` Joel Brobecker [this message]
2012-01-18 19:38 ` Jan Kratochvil
2012-01-18 20:01 ` Doug Evans
2012-01-19 6:30 ` Joel Brobecker
2012-01-19 12:57 ` [commit] rm gdb/testsuite/.gdbinit [Re: [patch] New set auto-load-local-gdbinit + disable it by default] Jan Kratochvil
2012-01-19 21:07 ` [patch] New set auto-load-local-gdbinit + disable it by default Tom Tromey
2012-01-19 21:47 ` Jan Kratochvil
2012-01-19 21:53 ` Doug Evans
2012-01-20 4:11 ` Jan Kratochvil
2012-01-19 21:06 ` Tom Tromey
2012-01-17 22:16 ` Doug Evans
2012-01-18 3:05 ` Tom Tromey
2012-01-17 16:26 ` Matt Rice
2012-01-17 16:57 ` Doug Evans
2012-01-17 20:09 ` Tom Tromey
2012-01-24 0:33 ` Stan Shebs
2012-01-24 15:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120118035927.GY31383@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox