From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>,
brobecker@adacore.com, gdb-patches@sourceware.org,
pedro@codesourcery.com
Subject: Re: Code formatting [Re: [patch] s390*: watchpoints regression [repost]]
Date: Sun, 18 Dec 2011 17:57:00 -0000 [thread overview]
Message-ID: <20111218172418.GA30764@host2.jankratochvil.net> (raw)
In-Reply-To: <83ty4xzusx.fsf@gnu.org>
On Sun, 18 Dec 2011 17:52:30 +0100, Eli Zaretskii wrote:
> Any reasons why no one says anything about the alternative I
> suggested? AFAIU, it is free from all the disadvantages mentioned
> here.
You dropped the important part about "still going through the shell", that was
the surprising fact to note there.
If you do not drop that shell part of the text the Pedro's text becomes
shorter, therefore more clear.
Also you just describe
/* This is the main thread still going through the shell, or, no
watchpoint has been set yet. */
->
/* Nothing else to do if this is the main thread, or if no
watchpoints have been set yet. */
additionally the "return" clause there. "return" does not need any comment.
Regards,
Jan
next prev parent reply other threads:[~2011-12-18 17:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 12:22 [obv] s390*: Fix build regression, remains execution regression Jan Kratochvil
2011-12-17 12:33 ` Pedro Alves
2011-12-17 19:37 ` [patch] s390*: watchpoints regression [Re: [obv] s390*: Fix build regression] Jan Kratochvil
2011-12-17 19:44 ` Pedro Alves
2011-12-17 19:45 ` Jan Kratochvil
2011-12-17 19:56 ` [patch] s390*: watchpoints regression [repost] Jan Kratochvil
2011-12-17 20:13 ` Pedro Alves
2011-12-17 20:35 ` Pedro Alves
2011-12-17 21:08 ` Jan Kratochvil
2011-12-18 6:37 ` Joel Brobecker
2011-12-18 10:11 ` Jan Kratochvil
2011-12-18 11:38 ` Joel Brobecker
2011-12-18 12:38 ` Code formatting [Re: [patch] s390*: watchpoints regression [repost]] Jan Kratochvil
2011-12-18 15:50 ` Mark Kettenis
2011-12-18 17:24 ` Eli Zaretskii
2011-12-18 17:57 ` Jan Kratochvil [this message]
2011-12-18 18:45 ` Eli Zaretskii
2011-12-20 14:29 ` Pedro Alves
2011-12-18 11:42 ` [patch] s390*: watchpoints regression [repost] Eli Zaretskii
2011-12-19 21:37 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111218172418.GA30764@host2.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox