Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [patch] s390*: watchpoints regression  [repost]
Date: Sun, 18 Dec 2011 10:11:00 -0000	[thread overview]
Message-ID: <20111218095850.GA19078@host2.jankratochvil.net> (raw)
In-Reply-To: <20111218062127.GE21915@adacore.com>

On Sun, 18 Dec 2011 07:21:27 +0100, Joel Brobecker wrote:
> > +  /* This is the main thread still going through the shell, or, no
> > +     watchpoint has been set yet.  */
> > +  if (lwp->arch_private == NULL)
> > +    return;
> 
> Just a really minor nitpick: Would you consider putting the comment
> inside the if, instead of just before? I think it'd be slightly clearer
> that way.

FYI I am aware of this rule and I try to follow it but it seems unnatural to
me.  It then requires new { brackets } and when reading the code I would more
expect to see why the conditional happens, not why the return happens.

But no problem continuing to follow this rule.


Thanks,
Jan


  reply	other threads:[~2011-12-18  9:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17 12:22 [obv] s390*: Fix build regression, remains execution regression Jan Kratochvil
2011-12-17 12:33 ` Pedro Alves
2011-12-17 19:37   ` [patch] s390*: watchpoints regression [Re: [obv] s390*: Fix build regression] Jan Kratochvil
2011-12-17 19:44     ` Pedro Alves
2011-12-17 19:45       ` Jan Kratochvil
2011-12-17 19:56         ` [patch] s390*: watchpoints regression [repost] Jan Kratochvil
2011-12-17 20:13           ` Pedro Alves
2011-12-17 20:35             ` Pedro Alves
2011-12-17 21:08               ` Jan Kratochvil
2011-12-18  6:37               ` Joel Brobecker
2011-12-18 10:11                 ` Jan Kratochvil [this message]
2011-12-18 11:38                   ` Joel Brobecker
2011-12-18 12:38                     ` Code formatting [Re: [patch] s390*: watchpoints regression [repost]] Jan Kratochvil
2011-12-18 15:50                       ` Mark Kettenis
2011-12-18 17:24                         ` Eli Zaretskii
2011-12-18 17:57                           ` Jan Kratochvil
2011-12-18 18:45                             ` Eli Zaretskii
2011-12-20 14:29                               ` Pedro Alves
2011-12-18 11:42                   ` [patch] s390*: watchpoints regression [repost] Eli Zaretskii
2011-12-19 21:37               ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111218095850.GA19078@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox