Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: [obv] s390*: Fix build regression, remains execution regression
Date: Sat, 17 Dec 2011 12:22:00 -0000	[thread overview]
Message-ID: <20111217094753.GA20113@host2.jankratochvil.net> (raw)

Hi Pedro,

this is the obvious part, checked in.

Unfortunately there is still a regression, it crashes during exec from the
wrapper->real inferior on mostly any program (kernel-2.6.32-220.el6.s390x):

61562 pts/1 T  \_ /root/jkratoch/redhat/archer-git/gdb/gdb -nx -x ./transcript.1
61568 pts/1 T      \_ /bin/bash -c exec /root/jkratoch/redhat/archer-git/gdb/testsuite/gdb.base/watchpoint-cond-gone

(gdb) run
Starting program: /root/jkratoch/redhat/archer-git/gdb/testsuite/gdb.base/watchpoint-cond-gone 
Couldn't retrieve watchpoint status: No such process.
Couldn't get registers: No such process.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-12/msg00175.html

--- src/gdb/ChangeLog	2011/12/17 06:14:44	1.13641
+++ src/gdb/ChangeLog	2011/12/17 09:43:53	1.13642
@@ -1,3 +1,9 @@
+2011-12-17  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	Fix build regression from the PR threads/10729 fix.
+	* s390-nat.c (s390_insert_watchpoint, s390_remove_watchpoint): Use LP,
+	not LP->PTID.
+
 2011-12-16  Andrey Smirnov  <andrew.smirnov@gmail.com>
 
 	* mi/mi-main.c (mi_cmd_list_thread_groups): Rename `optind' and
--- src/gdb/s390-nat.c	2011/12/14 17:20:31	1.36
+++ src/gdb/s390-nat.c	2011/12/17 09:43:53	1.37
@@ -532,7 +532,7 @@
   watch_base = area;
 
   ALL_LWPS (lp)
-    s390_fix_watch_points (lp->ptid);
+    s390_fix_watch_points (lp);
   return 0;
 }
 
@@ -560,7 +560,7 @@
   xfree (area);
 
   ALL_LWPS (lp)
-    s390_fix_watch_points (lp->ptid);
+    s390_fix_watch_points (lp);
   return 0;
 }
 


             reply	other threads:[~2011-12-17  9:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17 12:22 Jan Kratochvil [this message]
2011-12-17 12:33 ` Pedro Alves
2011-12-17 19:37   ` [patch] s390*: watchpoints regression [Re: [obv] s390*: Fix build regression] Jan Kratochvil
2011-12-17 19:44     ` Pedro Alves
2011-12-17 19:45       ` Jan Kratochvil
2011-12-17 19:56         ` [patch] s390*: watchpoints regression [repost] Jan Kratochvil
2011-12-17 20:13           ` Pedro Alves
2011-12-17 20:35             ` Pedro Alves
2011-12-17 21:08               ` Jan Kratochvil
2011-12-18  6:37               ` Joel Brobecker
2011-12-18 10:11                 ` Jan Kratochvil
2011-12-18 11:38                   ` Joel Brobecker
2011-12-18 12:38                     ` Code formatting [Re: [patch] s390*: watchpoints regression [repost]] Jan Kratochvil
2011-12-18 15:50                       ` Mark Kettenis
2011-12-18 17:24                         ` Eli Zaretskii
2011-12-18 17:57                           ` Jan Kratochvil
2011-12-18 18:45                             ` Eli Zaretskii
2011-12-20 14:29                               ` Pedro Alves
2011-12-18 11:42                   ` [patch] s390*: watchpoints regression [repost] Eli Zaretskii
2011-12-19 21:37               ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111217094753.GA20113@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox