From: Pedro Alves <alves.ped@gmail.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] s390*: watchpoints regression [Re: [obv] s390*: Fix build regression]
Date: Sat, 17 Dec 2011 19:44:00 -0000 [thread overview]
Message-ID: <201112171940.13962.alves.ped@gmail.com> (raw)
In-Reply-To: <20111217191543.GA5564@host2.jankratochvil.net>
On Saturday 17 December 2011 19:15:43, Jan Kratochvil wrote:
> I can confirm it works.
>
> On x86* it now sets DR_CONTROL to 0 already for the wrapper shell. When there
> exist watchpoints they are suppressed so it still sets 0 and it works. But
> I do not think GDB should mess with watchpoint registers already for the
> wrapper shell.
In the loop that runs through the shell, fork-child.c:startup_inferior,
nothing inserts breakpoints/watchpoints. So nothing ends up
setting lwp->arch_private->debug_registers_changed, and so we should
not be setting DR_CONTROL to 0 for the wrapper shell. Do you
actually see it happen?
> In the hypothetical case the wrapper shell sets DR registers they get
> inherited now by the inferior. Not that it needs to be handled but it IMO
> suggests DR_CONTROL should be rather set for the real inferior.
>
> But I do not see some easy enough way how to delay the DR setting till the new
> inferior so I just verified your code which works.
>
> OK to check it in this way?
Looks okay to me.
--
Pedro Alves
next prev parent reply other threads:[~2011-12-17 19:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-17 12:22 [obv] s390*: Fix build regression, remains execution regression Jan Kratochvil
2011-12-17 12:33 ` Pedro Alves
2011-12-17 19:37 ` [patch] s390*: watchpoints regression [Re: [obv] s390*: Fix build regression] Jan Kratochvil
2011-12-17 19:44 ` Pedro Alves [this message]
2011-12-17 19:45 ` Jan Kratochvil
2011-12-17 19:56 ` [patch] s390*: watchpoints regression [repost] Jan Kratochvil
2011-12-17 20:13 ` Pedro Alves
2011-12-17 20:35 ` Pedro Alves
2011-12-17 21:08 ` Jan Kratochvil
2011-12-18 6:37 ` Joel Brobecker
2011-12-18 10:11 ` Jan Kratochvil
2011-12-18 11:38 ` Joel Brobecker
2011-12-18 12:38 ` Code formatting [Re: [patch] s390*: watchpoints regression [repost]] Jan Kratochvil
2011-12-18 15:50 ` Mark Kettenis
2011-12-18 17:24 ` Eli Zaretskii
2011-12-18 17:57 ` Jan Kratochvil
2011-12-18 18:45 ` Eli Zaretskii
2011-12-20 14:29 ` Pedro Alves
2011-12-18 11:42 ` [patch] s390*: watchpoints regression [repost] Eli Zaretskii
2011-12-19 21:37 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201112171940.13962.alves.ped@gmail.com \
--to=alves.ped@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox