Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Replace magic numbers with macros in gdbserver/tracepoint.c
Date: Mon, 12 Dec 2011 11:21:00 -0000	[thread overview]
Message-ID: <20111212094348.GB31707@host2.jankratochvil.net> (raw)
In-Reply-To: <4EE5674B.7050205@codesourcery.com>

On Mon, 12 Dec 2011 03:30:35 +0100, Yao Qi wrote:
> -    ipa_trace_buffer_ctrl_curr = (0x80000000
> +    ipa_trace_buffer_ctrl_curr = ( GDBSERVER_UPDATED_FLUSH_COUNT_BIT
                                     ^ excessive space
therefore:
# +    ipa_trace_buffer_ctrl_curr = (GDBSERVER_UPDATED_FLUSH_COUNT_BIT


>  				  | (prev << 12)
>  				  | counter
>  				  | curr_tbctrl_idx);

I have verified the constants.


Thanks,
Jan


  reply	other threads:[~2011-12-12  9:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  9:39 Yao Qi
2011-12-12 11:21 ` Jan Kratochvil [this message]
2011-12-13  2:03   ` [committed] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111212094348.GB31707@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox