From: Yao Qi <yao@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: <gdb-patches@sourceware.org>
Subject: [committed] [patch] Replace magic numbers with macros in gdbserver/tracepoint.c
Date: Tue, 13 Dec 2011 02:03:00 -0000 [thread overview]
Message-ID: <4EE6AA12.8070006@codesourcery.com> (raw)
In-Reply-To: <20111212094348.GB31707@host2.jankratochvil.net>
On 12/12/2011 05:43 PM, Jan Kratochvil wrote:
> On Mon, 12 Dec 2011 03:30:35 +0100, Yao Qi wrote:
>> - ipa_trace_buffer_ctrl_curr = (0x80000000
>> + ipa_trace_buffer_ctrl_curr = ( GDBSERVER_UPDATED_FLUSH_COUNT_BIT
> ^ excessive space
> therefore:
> # + ipa_trace_buffer_ctrl_curr = (GDBSERVER_UPDATED_FLUSH_COUNT_BIT
>
Right, get it fixed.
>
>> | (prev << 12)
>> | counter
>> | curr_tbctrl_idx);
>
> I have verified the constants.
>
Thanks for the review. Committed.
http://sourceware.org/ml/gdb-cvs/2011-12/msg00106.html
--
Yao (é½å°§)
prev parent reply other threads:[~2011-12-13 1:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 9:39 Yao Qi
2011-12-12 11:21 ` Jan Kratochvil
2011-12-13 2:03 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE6AA12.8070006@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox