From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6088 invoked by alias); 13 Dec 2011 01:28:07 -0000 Received: (qmail 6079 invoked by uid 22791); 13 Dec 2011 01:28:07 -0000 X-SWARE-Spam-Status: No, hits=-1.0 required=5.0 tests=AWL,BAYES_00,FROM_12LTRDOM X-Spam-Check-By: sourceware.org Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Dec 2011 01:27:52 +0000 Received: from svr-orw-fem-01.mgc.mentorg.com ([147.34.98.93]) by relay1.mentorg.com with esmtp id 1RaH9q-0000G5-E3 from Yao_Qi@mentor.com ; Mon, 12 Dec 2011 17:27:50 -0800 Received: from SVR-ORW-FEM-02.mgc.mentorg.com ([147.34.96.206]) by svr-orw-fem-01.mgc.mentorg.com over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Mon, 12 Dec 2011 17:27:50 -0800 Received: from [127.0.0.1] (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.1.289.1; Mon, 12 Dec 2011 17:27:49 -0800 Message-ID: <4EE6AA12.8070006@codesourcery.com> Date: Tue, 13 Dec 2011 02:03:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:8.0) Gecko/20111110 Thunderbird/8.0 MIME-Version: 1.0 To: Jan Kratochvil CC: Subject: [committed] [patch] Replace magic numbers with macros in gdbserver/tracepoint.c References: <4EE5674B.7050205@codesourcery.com> <20111212094348.GB31707@host2.jankratochvil.net> In-Reply-To: <20111212094348.GB31707@host2.jankratochvil.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-12/txt/msg00357.txt.bz2 On 12/12/2011 05:43 PM, Jan Kratochvil wrote: > On Mon, 12 Dec 2011 03:30:35 +0100, Yao Qi wrote: >> - ipa_trace_buffer_ctrl_curr = (0x80000000 >> + ipa_trace_buffer_ctrl_curr = ( GDBSERVER_UPDATED_FLUSH_COUNT_BIT > ^ excessive space > therefore: > # + ipa_trace_buffer_ctrl_curr = (GDBSERVER_UPDATED_FLUSH_COUNT_BIT > Right, get it fixed. > >> | (prev << 12) >> | counter >> | curr_tbctrl_idx); > > I have verified the constants. > Thanks for the review. Committed. http://sourceware.org/ml/gdb-cvs/2011-12/msg00106.html -- Yao (齐尧)