From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-86025-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19533 invoked by alias); 12 Dec 2011 09:44:11 -0000
Received: (qmail 19522 invoked by uid 22791); 12 Dec 2011 09:44:10 -0000
X-SWARE-Spam-Status: No, hits=-7.7 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 12 Dec 2011 09:43:57 +0000
Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pBC9hr2M001712	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Mon, 12 Dec 2011 04:43:53 -0500
Received: from host2.jankratochvil.net (ovpn-116-39.ams2.redhat.com [10.36.116.39])	by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pBC9hnmu021344	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 12 Dec 2011 04:43:52 -0500
Date: Mon, 12 Dec 2011 11:21:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Replace magic numbers with macros in gdbserver/tracepoint.c
Message-ID: <20111212094348.GB31707@host2.jankratochvil.net>
References: <4EE5674B.7050205@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4EE5674B.7050205@codesourcery.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-12/txt/msg00344.txt.bz2

On Mon, 12 Dec 2011 03:30:35 +0100, Yao Qi wrote:
> -    ipa_trace_buffer_ctrl_curr = (0x80000000
> +    ipa_trace_buffer_ctrl_curr = ( GDBSERVER_UPDATED_FLUSH_COUNT_BIT
                                     ^ excessive space
therefore:
# +    ipa_trace_buffer_ctrl_curr = (GDBSERVER_UPDATED_FLUSH_COUNT_BIT


>  				  | (prev << 12)
>  				  | counter
>  				  | curr_tbctrl_idx);

I have verified the constants.


Thanks,
Jan