Re: [patch] Replace magic numbers with macros in gdbserver/tracepoint.c

Jan Kratochvil
2011-12-12T09:44:11Z

On Mon, 12 Dec 2011 03:30:35 +0100, Yao Qi wrote:
> - ipa_trace_buffer_ctrl_curr = (0x80000000
> + ipa_trace_buffer_ctrl_curr = ( GDBSERVER_UPDATED_FLUSH_COUNT_BIT
^ excessive space
therefore:
# + ipa_trace_buffer_ctrl_curr = (GDBSERVER_UPDATED_FLUSH_COUNT_BIT

> | (prev << 12)
> | counter
> | curr_tbctrl_idx);

I have verified the constants.

Thanks,
Jan