From: Joel Brobecker <brobecker@adacore.com>
To: Andrey Smirnov <andrew.smirnov@gmail.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 18/348] Fix -Wsahdow warnings
Date: Fri, 25 Nov 2011 14:26:00 -0000 [thread overview]
Message-ID: <20111125142615.GV13809@adacore.com> (raw)
In-Reply-To: <CAHQ1cqGEctu8NQ6hHAbz1oC5x_M0Uc_gp-FZr3Fav_LEZrHwaQ@mail.gmail.com>
> Thanks for bringing that up, that is, IMHO, an excellent example.
> The `block_found' in function conflicts with global variable declared
> in symtab.c and it is not that just their names match, types are very
> similar too one is `struct block **' another is `const struct *block'.
Hmmm, I don't know how I missed that, as I grep'ed the source code.
Or so I thought. Maybe a typo.
In this particular case, yes, I agree, we should do something. We might
prefer to rename the global variable, though; I think that a global
variable with that name is bizarre.
As to the final decision of enabling -Wshadow by default, I agree
a little more to the idea, although not quite convinced yet. So far,
Eli is pro. Mark is against. I'm 50/50. Unless we get more feedback
from other GMs, you've done the work, we could at least try it and
see where that gets us.
--
Joel
next prev parent reply other threads:[~2011-11-25 14:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:01 Andrey Smirnov
2011-11-22 18:03 ` Tom Tromey
2011-11-23 16:36 ` Mark Kettenis
2011-11-23 16:41 ` Ulrich Weigand
2011-11-23 18:21 ` Pedro Alves
2011-11-23 18:42 ` Joel Brobecker
2011-11-23 20:24 ` Mark Kettenis
2011-11-24 4:16 ` Andrey Smirnov
2011-11-24 11:36 ` Eli Zaretskii
2011-11-24 22:01 ` Joel Brobecker
2011-11-25 0:48 ` Andrey Smirnov
2011-11-25 14:26 ` Joel Brobecker [this message]
2011-11-25 15:52 ` About adding -Wshadow option by default (was Re: [PATCH 18/348] Fix -Wsahdow warnings) Pierre Muller
2011-11-25 16:36 ` Mark Kettenis
2011-11-29 19:18 ` [PATCH 18/348] Fix -Wsahdow warnings Tom Tromey
2011-11-30 3:48 ` Andrey Smirnov
2011-11-30 14:59 ` Tom Tromey
2011-12-01 4:15 ` Andrey Smirnov
2011-12-02 17:08 ` Tom Tromey
2011-11-25 12:03 ` Eli Zaretskii
2011-11-25 15:11 ` Mark Kettenis
2011-11-25 15:41 ` Eli Zaretskii
2011-11-25 16:26 ` Mark Kettenis
2011-11-25 18:20 ` Eli Zaretskii
2011-11-27 13:53 ` Mark Kettenis
2011-11-27 14:55 ` Pedro Alves
2011-11-27 16:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111125142615.GV13809@adacore.com \
--to=brobecker@adacore.com \
--cc=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox