From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5190 invoked by alias); 25 Nov 2011 14:26:38 -0000 Received: (qmail 5182 invoked by uid 22791); 25 Nov 2011 14:26:37 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 25 Nov 2011 14:26:23 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 768F12BB5B4; Fri, 25 Nov 2011 09:26:22 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 1mEqb96OUfoi; Fri, 25 Nov 2011 09:26:22 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 49BBC2BB5B0; Fri, 25 Nov 2011 09:26:22 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 2064B145615; Fri, 25 Nov 2011 09:26:15 -0500 (EST) Date: Fri, 25 Nov 2011 14:26:00 -0000 From: Joel Brobecker To: Andrey Smirnov Cc: gdb-patches Subject: Re: [PATCH 18/348] Fix -Wsahdow warnings Message-ID: <20111125142615.GV13809@adacore.com> References: <201111231640.pANGefc4031803@d06av02.portsmouth.uk.ibm.com> <201111231820.40486.pedro@codesourcery.com> <201111232023.pANKNcLf022983@glazunov.sibelius.xs4all.nl> <20111124220057.GU13809@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00695.txt.bz2 > Thanks for bringing that up, that is, IMHO, an excellent example. > The `block_found' in function conflicts with global variable declared > in symtab.c and it is not that just their names match, types are very > similar too one is `struct block **' another is `const struct *block'. Hmmm, I don't know how I missed that, as I grep'ed the source code. Or so I thought. Maybe a typo. In this particular case, yes, I agree, we should do something. We might prefer to rename the global variable, though; I think that a global variable with that name is bizarre. As to the final decision of enabling -Wshadow by default, I agree a little more to the idea, although not quite convinced yet. So far, Eli is pro. Mark is against. I'm 50/50. Unless we get more feedback from other GMs, you've done the work, we could at least try it and see where that gets us. -- Joel