From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Ulrich Weigand" <uweigand@de.ibm.com>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
andrew.smirnov@gmail.com
Subject: Re: [PATCH 18/348] Fix -Wsahdow warnings
Date: Wed, 23 Nov 2011 18:21:00 -0000 [thread overview]
Message-ID: <201111231820.40486.pedro@codesourcery.com> (raw)
In-Reply-To: <201111231640.pANGefc4031803@d06av02.portsmouth.uk.ibm.com>
On Wednesday 23 November 2011 16:40:41, Ulrich Weigand wrote:
> Mark Kettenis wrote:
>
> > > From: Andrey Smirnov <andrew.smirnov@gmail.com>
> > > Date: Tue, 22 Nov 2011 17:25:56 +0700
> > > Subject: [PATCH 18/39] Fix -Wshadow warnings.
> > >
> > > * amd64-linux-tdep.c (amd64_canonicalize_syscall): Fix -Wshadow
> > > warnings.
> >
> > Why the hell does -Wshadow complain here?
>
> > > -amd64_canonicalize_syscall (enum amd64_syscall syscall)
> > > +amd64_canonicalize_syscall (enum amd64_syscall syscall_number)
>
> I'd expect this is because the parameter "syscall" shadows the global
> function declaration "syscall" provided by glibc headers:
>
> /usr/include/unistd.h:extern long int syscall (long int __sysno, ...) __THROW;
Yeah, this is unfortunate because it means you trigger different
shadows on different hosts, or by configuring gdb differently.
There was this gcc patch
http://comments.gmane.org/gmane.comp.gcc.patches/244771
to stop -Wshadow from complaning about shadowing of symbols in system
headers, but it doesn't seem to have been applied, though it was okayed.
--
Pedro Alves
next prev parent reply other threads:[~2011-11-23 18:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:01 Andrey Smirnov
2011-11-22 18:03 ` Tom Tromey
2011-11-23 16:36 ` Mark Kettenis
2011-11-23 16:41 ` Ulrich Weigand
2011-11-23 18:21 ` Pedro Alves [this message]
2011-11-23 18:42 ` Joel Brobecker
2011-11-23 20:24 ` Mark Kettenis
2011-11-24 4:16 ` Andrey Smirnov
2011-11-24 11:36 ` Eli Zaretskii
2011-11-24 22:01 ` Joel Brobecker
2011-11-25 0:48 ` Andrey Smirnov
2011-11-25 14:26 ` Joel Brobecker
2011-11-25 15:52 ` About adding -Wshadow option by default (was Re: [PATCH 18/348] Fix -Wsahdow warnings) Pierre Muller
2011-11-25 16:36 ` Mark Kettenis
2011-11-29 19:18 ` [PATCH 18/348] Fix -Wsahdow warnings Tom Tromey
2011-11-30 3:48 ` Andrey Smirnov
2011-11-30 14:59 ` Tom Tromey
2011-12-01 4:15 ` Andrey Smirnov
2011-12-02 17:08 ` Tom Tromey
2011-11-25 12:03 ` Eli Zaretskii
2011-11-25 15:11 ` Mark Kettenis
2011-11-25 15:41 ` Eli Zaretskii
2011-11-25 16:26 ` Mark Kettenis
2011-11-25 18:20 ` Eli Zaretskii
2011-11-27 13:53 ` Mark Kettenis
2011-11-27 14:55 ` Pedro Alves
2011-11-27 16:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111231820.40486.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox