From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: andrew.smirnov@gmail.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 18/348] Fix -Wsahdow warnings
Date: Wed, 23 Nov 2011 16:36:00 -0000 [thread overview]
Message-ID: <201111231636.pANGa165005809@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <87ehx08g69.fsf@gmail.com> (message from Andrey Smirnov on Tue, 22 Nov 2011 20:01:18 +0700)
> From: Andrey Smirnov <andrew.smirnov@gmail.com>
> Date: Tue, 22 Nov 2011 20:01:18 +0700
>
> >From 6347add7f352c5e9994f7a5de938e8a7dacc98f9 Mon Sep 17 00:00:00 2001
> From: Andrey Smirnov <andrew.smirnov@gmail.com>
> Date: Tue, 22 Nov 2011 17:25:56 +0700
> Subject: [PATCH 18/39] Fix -Wshadow warnings.
>
> * amd64-linux-tdep.c (amd64_canonicalize_syscall): Fix -Wshadow
> warnings.
Why the hell does -Wshadow complain here?
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index 54284cf..7f049a8 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,3 +1,8 @@
> +2011-11-22 Andrey Smirnov <andrew.smirnov@gmail.com>
> +
> + * amd64-linux-tdep.c (amd64_canonicalize_syscall): Fix -Wshadow
> + warnings.
> +
> 2011-11-19 Andrey Smirnov <andrew.smirnov@gmail.com>
>
> * ada-valprint.c (ada_val_print_1): Fix -Wshadow warnings.
> diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c
> index 0119838..84b58a0 100644
> --- a/gdb/amd64-linux-tdep.c
> +++ b/gdb/amd64-linux-tdep.c
> @@ -339,9 +339,9 @@ amd64_all_but_ip_registers_record (struct regcache *regcache)
> process record. */
>
> static enum gdb_syscall
> -amd64_canonicalize_syscall (enum amd64_syscall syscall)
> +amd64_canonicalize_syscall (enum amd64_syscall syscall_number)
> {
> - switch (syscall) {
> + switch (syscall_number) {
> case amd64_sys_read:
> return gdb_sys_read;
>
> --
> 1.7.5.4
>
>
next prev parent reply other threads:[~2011-11-23 16:36 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 13:01 Andrey Smirnov
2011-11-22 18:03 ` Tom Tromey
2011-11-23 16:36 ` Mark Kettenis [this message]
2011-11-23 16:41 ` Ulrich Weigand
2011-11-23 18:21 ` Pedro Alves
2011-11-23 18:42 ` Joel Brobecker
2011-11-23 20:24 ` Mark Kettenis
2011-11-24 4:16 ` Andrey Smirnov
2011-11-24 11:36 ` Eli Zaretskii
2011-11-24 22:01 ` Joel Brobecker
2011-11-25 0:48 ` Andrey Smirnov
2011-11-25 14:26 ` Joel Brobecker
2011-11-25 15:52 ` About adding -Wshadow option by default (was Re: [PATCH 18/348] Fix -Wsahdow warnings) Pierre Muller
2011-11-25 16:36 ` Mark Kettenis
2011-11-29 19:18 ` [PATCH 18/348] Fix -Wsahdow warnings Tom Tromey
2011-11-30 3:48 ` Andrey Smirnov
2011-11-30 14:59 ` Tom Tromey
2011-12-01 4:15 ` Andrey Smirnov
2011-12-02 17:08 ` Tom Tromey
2011-11-25 12:03 ` Eli Zaretskii
2011-11-25 15:11 ` Mark Kettenis
2011-11-25 15:41 ` Eli Zaretskii
2011-11-25 16:26 ` Mark Kettenis
2011-11-25 18:20 ` Eli Zaretskii
2011-11-27 13:53 ` Mark Kettenis
2011-11-27 14:55 ` Pedro Alves
2011-11-27 16:35 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201111231636.pANGa165005809@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=andrew.smirnov@gmail.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox