From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Doug Evans <dje@google.com>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [patch] print-threads.exp: Extend timeout for slower tests.
Date: Tue, 08 Nov 2011 09:01:00 -0000 [thread overview]
Message-ID: <20111108090031.GA27209@host1.jankratochvil.net> (raw)
In-Reply-To: <CADPb22SWZmfqR5g=51-4e5QS61ciwfqNZGFhugMfQ9rgw+iRng@mail.gmail.com>
On Tue, 08 Nov 2011 09:11:31 +0100, Doug Evans wrote:
> There are no existing uses of gdb_test_timeout outside of lib/gdb.exp,
> and regardless, I prefer my patch. "timeout" is a standard global variable
> .exp writers know about. Adding gdb_test_timeout is one more global,
...
> Once I'm in a testsuite .exp file, I'd rather not have to involve it
> in my hacking.
Every GDB .exp has to heavily depend on lib/gdb.exp.
And for new GDB contributors TCL is exactly as new as lib/gdb.exp.
I see it was not misunderstanding but rather a real disagreement.
I do not mind, this is just bikeshedding, other patches need more reviews.
Thanks,
Jan
prev parent reply other threads:[~2011-11-08 9:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 22:12 Doug Evans
2011-11-02 23:22 ` Jan Kratochvil
2011-11-03 15:47 ` Doug Evans
2011-11-07 16:22 ` Joel Brobecker
2011-11-08 7:56 ` Jan Kratochvil
2011-11-08 8:11 ` Doug Evans
2011-11-08 9:01 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111108090031.GA27209@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox