From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [patch] print-threads.exp: Extend timeout for slower tests.
Date: Wed, 02 Nov 2011 22:12:00 -0000 [thread overview]
Message-ID: <20111102221154.8A3C12461B1@ruffy.mtv.corp.google.com> (raw)
Hi.
This test can errantly fail due to timeouts,
so this patch extends the timeout for the slower tests.
I will commit this in a few days if there are no objections.
2011-11-02 Doug Evans <dje@google.com>
* testsuite/gdb.threads/print-threads.exp: Extend timeout for slower
tests.
Index: print-threads.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/print-threads.exp,v
retrieving revision 1.19
diff -u -p -r1.19 print-threads.exp
--- print-threads.exp 7 Mar 2011 16:03:03 -0000 1.19
+++ print-threads.exp 2 Nov 2011 22:09:35 -0000
@@ -98,6 +98,9 @@ proc test_all_threads { name kill } {
}
}
+# Record the old timeout, we need to extend it for slower tests.
+set oldtimeout $timeout
+
runto_main
gdb_test "break thread_function" "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*print-threads.c, line \[0-9\]*\\."
gdb_test_no_output "set var slow = 0"
@@ -106,12 +109,18 @@ test_all_threads "fast" 0
runto_main
gdb_test "break thread_function" "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*print-threads.c, line \[0-9\]*\\." "break thread_function (2)"
gdb_test_no_output "set var slow = 1"
+# Extend the timeout for slower tests.
+set timeout [expr $oldtimeout + 120]
test_all_threads "slow" 0
+set $timeout $oldtimeout
runto_main
gdb_test "break thread_function" "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*print-threads.c, line \[0-9\]*\\." "break thread_function (3)"
gdb_test_no_output "set var slow = 1" "set var slow = 1 (2)"
gdb_breakpoint "kill"
+# Extend the timeout for slower tests.
+set timeout [expr $oldtimeout + 120]
test_all_threads "slow with kill breakpoint" 1
+set $timeout $oldtimeout
return 0
next reply other threads:[~2011-11-02 22:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 22:12 Doug Evans [this message]
2011-11-02 23:22 ` Jan Kratochvil
2011-11-03 15:47 ` Doug Evans
2011-11-07 16:22 ` Joel Brobecker
2011-11-08 7:56 ` Jan Kratochvil
2011-11-08 8:11 ` Doug Evans
2011-11-08 9:01 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111102221154.8A3C12461B1@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox