From: Joel Brobecker <brobecker@adacore.com>
To: Doug Evans <dje@google.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] print-threads.exp: Extend timeout for slower tests.
Date: Mon, 07 Nov 2011 16:22:00 -0000 [thread overview]
Message-ID: <20111107162202.GG14508@adacore.com> (raw)
In-Reply-To: <CADPb22SAVLU5mYZNkDTym_9KAKqtOAwchZZTvwcangeRt7LwaA@mail.gmail.com>
> >> +# Record the old timeout, we need to extend it for slower tests.
> >> +set oldtimeout $timeout
> >
> > You can use global $gdb_test_timeout nowadays.
>
> Thanks, I didn't know about gdb_test_timeout.
> Still, I like the patch as is, one less global the code has to care about.
Same here. I don't think that this variable is meant to be changed
by testcases when you just want to change it for a few tests.
Otherwise, you run the risk of affecting all the other testcases,
which set the timeout to $gdb_test_timeout at the start of every
testcase (this was done to prevent a change of timeout duration
from affecting subsequent testcases). See gdb_init:
# Reset the timeout value to the default. This way, any testcase
# that changes the timeout value without resetting it cannot affect
# the timeout used in subsequent testcases.
global gdb_test_timeout
global timeout
set timeout $gdb_test_timeout
--
Joel
next prev parent reply other threads:[~2011-11-07 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 22:12 Doug Evans
2011-11-02 23:22 ` Jan Kratochvil
2011-11-03 15:47 ` Doug Evans
2011-11-07 16:22 ` Joel Brobecker [this message]
2011-11-08 7:56 ` Jan Kratochvil
2011-11-08 8:11 ` Doug Evans
2011-11-08 9:01 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111107162202.GG14508@adacore.com \
--to=brobecker@adacore.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox