From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27339 invoked by alias); 7 Nov 2011 16:22:26 -0000 Received: (qmail 27324 invoked by uid 22791); 7 Nov 2011 16:22:23 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Nov 2011 16:22:08 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5233A2BAF4D; Mon, 7 Nov 2011 11:22:08 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id ncDiK9HWcfQG; Mon, 7 Nov 2011 11:22:08 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0B6572BAF48; Mon, 7 Nov 2011 11:22:07 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 182D0145615; Mon, 7 Nov 2011 11:22:02 -0500 (EST) Date: Mon, 07 Nov 2011 16:22:00 -0000 From: Joel Brobecker To: Doug Evans Cc: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] print-threads.exp: Extend timeout for slower tests. Message-ID: <20111107162202.GG14508@adacore.com> References: <20111102221154.8A3C12461B1@ruffy.mtv.corp.google.com> <20111102232147.GA7605@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00157.txt.bz2 > >> +# Record the old timeout, we need to extend it for slower tests. > >> +set oldtimeout $timeout > > > > You can use global $gdb_test_timeout nowadays. > > Thanks, I didn't know about gdb_test_timeout. > Still, I like the patch as is, one less global the code has to care about. Same here. I don't think that this variable is meant to be changed by testcases when you just want to change it for a few tests. Otherwise, you run the risk of affecting all the other testcases, which set the timeout to $gdb_test_timeout at the start of every testcase (this was done to prevent a change of timeout duration from affecting subsequent testcases). See gdb_init: # Reset the timeout value to the default. This way, any testcase # that changes the timeout value without resetting it cannot affect # the timeout used in subsequent testcases. global gdb_test_timeout global timeout set timeout $gdb_test_timeout -- Joel