From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29584 invoked by alias); 2 Nov 2011 22:12:17 -0000 Received: (qmail 29572 invoked by uid 22791); 2 Nov 2011 22:12:16 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 02 Nov 2011 22:12:01 +0000 Received: from wpaz37.hot.corp.google.com (wpaz37.hot.corp.google.com [172.24.198.101]) by smtp-out.google.com with ESMTP id pA2MC1hR019332 for ; Wed, 2 Nov 2011 15:12:01 -0700 Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.18.110.50]) by wpaz37.hot.corp.google.com with ESMTP id pA2MBxLM021036 for ; Wed, 2 Nov 2011 15:12:00 -0700 Received: by ruffy.mtv.corp.google.com (Postfix, from userid 67641) id 8A3C12461B1; Wed, 2 Nov 2011 15:11:54 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [patch] print-threads.exp: Extend timeout for slower tests. Message-Id: <20111102221154.8A3C12461B1@ruffy.mtv.corp.google.com> Date: Wed, 02 Nov 2011 22:12:00 -0000 From: dje@google.com (Doug Evans) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00055.txt.bz2 Hi. This test can errantly fail due to timeouts, so this patch extends the timeout for the slower tests. I will commit this in a few days if there are no objections. 2011-11-02 Doug Evans * testsuite/gdb.threads/print-threads.exp: Extend timeout for slower tests. Index: print-threads.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.threads/print-threads.exp,v retrieving revision 1.19 diff -u -p -r1.19 print-threads.exp --- print-threads.exp 7 Mar 2011 16:03:03 -0000 1.19 +++ print-threads.exp 2 Nov 2011 22:09:35 -0000 @@ -98,6 +98,9 @@ proc test_all_threads { name kill } { } } +# Record the old timeout, we need to extend it for slower tests. +set oldtimeout $timeout + runto_main gdb_test "break thread_function" "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*print-threads.c, line \[0-9\]*\\." gdb_test_no_output "set var slow = 0" @@ -106,12 +109,18 @@ test_all_threads "fast" 0 runto_main gdb_test "break thread_function" "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*print-threads.c, line \[0-9\]*\\." "break thread_function (2)" gdb_test_no_output "set var slow = 1" +# Extend the timeout for slower tests. +set timeout [expr $oldtimeout + 120] test_all_threads "slow" 0 +set $timeout $oldtimeout runto_main gdb_test "break thread_function" "Breakpoint \[0-9\]+ at 0x\[0-9a-f\]+: file .*print-threads.c, line \[0-9\]*\\." "break thread_function (3)" gdb_test_no_output "set var slow = 1" "set var slow = 1 (2)" gdb_breakpoint "kill" +# Extend the timeout for slower tests. +set timeout [expr $oldtimeout + 120] test_all_threads "slow with kill breakpoint" 1 +set $timeout $oldtimeout return 0