From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4516 invoked by alias); 8 Nov 2011 09:01:19 -0000 Received: (qmail 4506 invoked by uid 22791); 8 Nov 2011 09:01:18 -0000 X-SWARE-Spam-Status: No, hits=-7.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Nov 2011 09:00:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA890aj1030484 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 8 Nov 2011 04:00:36 -0500 Received: from host1.jankratochvil.net (ovpn-116-24.ams2.redhat.com [10.36.116.24]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA890XOv007300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 8 Nov 2011 04:00:35 -0500 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id pA890Wrx027353; Tue, 8 Nov 2011 10:00:32 +0100 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id pA890Vvr027352; Tue, 8 Nov 2011 10:00:31 +0100 Date: Tue, 08 Nov 2011 09:01:00 -0000 From: Jan Kratochvil To: Doug Evans Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [patch] print-threads.exp: Extend timeout for slower tests. Message-ID: <20111108090031.GA27209@host1.jankratochvil.net> References: <20111102221154.8A3C12461B1@ruffy.mtv.corp.google.com> <20111102232147.GA7605@host1.jankratochvil.net> <20111107162202.GG14508@adacore.com> <20111108075608.GA22184@host1.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00184.txt.bz2 On Tue, 08 Nov 2011 09:11:31 +0100, Doug Evans wrote: > There are no existing uses of gdb_test_timeout outside of lib/gdb.exp, > and regardless, I prefer my patch. "timeout" is a standard global variable > .exp writers know about. Adding gdb_test_timeout is one more global, ... > Once I'm in a testsuite .exp file, I'd rather not have to involve it > in my hacking. Every GDB .exp has to heavily depend on lib/gdb.exp. And for new GDB contributors TCL is exactly as new as lib/gdb.exp. I see it was not misunderstanding but rather a real disagreement. I do not mind, this is just bikeshedding, other patches need more reviews. Thanks, Jan