Re: [PATCH] sim: use AC_REQUIRE with AC_PROG_CC

[Joel Brobecker <brobecker@adacore.com>]

> 2011-07-11  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* aclocal.m4 (SIM_AC_COMMON): Call AC_REQUIRE on AC_PROG_CC.
> 	Delete direct call to AC_PROG_CC.

Looks, OK, except why did you move the call up?

Looking at the autoconf documentation, AC_CONFIG_HEADER does not need
to be called right after AC_INIT, it is only customary. So if there is
a reason for us to change the location of the use of AC_PROG_CC, we
probably want to fix the comment as well.

> ---
>  sim/common/aclocal.m4 |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/sim/common/aclocal.m4 b/sim/common/aclocal.m4
> index 264cced..3ed5efd 100644
> --- a/sim/common/aclocal.m4
> +++ b/sim/common/aclocal.m4
> @@ -24,11 +24,11 @@ sinclude([../../config/zlib.m4])
>  
>  AC_DEFUN([SIM_AC_COMMON],
>  [
> +AC_REQUIRE([AC_PROG_CC])
>  # autoconf.info says this should be called right after AC_INIT.
>  AC_CONFIG_HEADER(ifelse([$1],,config.h,[$1]):config.in)
>  AC_CANONICAL_SYSTEM
>  AC_ARG_PROGRAM
> -AC_PROG_CC
>  AC_PROG_INSTALL
>  
>  # Put a plausible default for CC_FOR_BUILD in Makefile.
> -- 
> 1.7.6

-- 
Joel