Re: [PATCH] sim: use AC_REQUIRE with AC_PROG_CC

[Mike Frysinger <vapier@gentoo.org>]

On Monday 17 October 2011 12:57:24 Joel Brobecker wrote:
> > 2011-07-11  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* aclocal.m4 (SIM_AC_COMMON): Call AC_REQUIRE on AC_PROG_CC.
> > 	Delete direct call to AC_PROG_CC.
> 
> Looks, OK, except why did you move the call up?
> 
> Looking at the autoconf documentation, AC_CONFIG_HEADER does not need
> to be called right after AC_INIT, it is only customary. So if there is
> a reason for us to change the location of the use of AC_PROG_CC, we
> probably want to fix the comment as well.

i don't think there is a requirement for the AC_REQUIRE to be where it is; 
i'll have to double check.  the reason i moved it is that the convention i've 
seen when reading other GNU projects is to put unconditional AC_REQUIRE calls 
at the top of m4 defines.  SIM_AC_COMMON is probably a bit of a special case 
though due to it mostly being the normal configure.ac file.

i can move it back if you like (and i verify that it works fine).
-mike