From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6860 invoked by alias); 17 Oct 2011 17:15:23 -0000 Received: (qmail 6849 invoked by uid 22791); 17 Oct 2011 17:15:22 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 17:15:08 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 3EAE81B4042; Mon, 17 Oct 2011 17:15:07 +0000 (UTC) From: Mike Frysinger To: Joel Brobecker Subject: Re: [PATCH] sim: use AC_REQUIRE with AC_PROG_CC Date: Mon, 17 Oct 2011 17:17:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.1.0-rc4; KDE/4.6.5; x86_64; ; ) Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org References: <1310418640-32168-1-git-send-email-vapier@gentoo.org> <20111017165724.GC17942@adacore.com> In-Reply-To: <20111017165724.GC17942@adacore.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201110171315.07219.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00478.txt.bz2 On Monday 17 October 2011 12:57:24 Joel Brobecker wrote: > > 2011-07-11 Mike Frysinger > > > > * aclocal.m4 (SIM_AC_COMMON): Call AC_REQUIRE on AC_PROG_CC. > > Delete direct call to AC_PROG_CC. > > Looks, OK, except why did you move the call up? > > Looking at the autoconf documentation, AC_CONFIG_HEADER does not need > to be called right after AC_INIT, it is only customary. So if there is > a reason for us to change the location of the use of AC_PROG_CC, we > probably want to fix the comment as well. i don't think there is a requirement for the AC_REQUIRE to be where it is; i'll have to double check. the reason i moved it is that the convention i've seen when reading other GNU projects is to put unconditional AC_REQUIRE calls at the top of m4 defines. SIM_AC_COMMON is probably a bit of a special case though due to it mostly being the normal configure.ac file. i can move it back if you like (and i verify that it works fine). -mike