From: Joel Brobecker <brobecker@adacore.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org
Subject: Re: [PATCH] sim: use AC_REQUIRE with AC_PROG_CC
Date: Mon, 17 Oct 2011 18:23:00 -0000 [thread overview]
Message-ID: <20111017173000.GA19246@adacore.com> (raw)
In-Reply-To: <201110171315.07219.vapier@gentoo.org>
> i don't think there is a requirement for the AC_REQUIRE to be where it is;
> i'll have to double check. the reason i moved it is that the convention i've
> seen when reading other GNU projects is to put unconditional AC_REQUIRE calls
> at the top of m4 defines. SIM_AC_COMMON is probably a bit of a special case
> though due to it mostly being the normal configure.ac file.
>
> i can move it back if you like (and i verify that it works fine).
Nah, that's Ok. The comment right after is what prompted the question,
and it is a bit misleading. I'd just remove it (as a follow up patch)
I think, it doesn't bring anything anyway.
--
Joel
next prev parent reply other threads:[~2011-10-17 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 23:32 Mike Frysinger
2011-10-17 17:01 ` Joel Brobecker
2011-10-17 17:17 ` Mike Frysinger
2011-10-17 18:23 ` Joel Brobecker [this message]
[not found] <1310418640-32168-1-git-send-email-vapier__8759.03008641235$1310418652$gmane$org@gentoo.org>
2011-07-12 19:48 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111017173000.GA19246@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=toolchain-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox