From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30306 invoked by alias); 17 Oct 2011 16:57:45 -0000 Received: (qmail 30280 invoked by uid 22791); 17 Oct 2011 16:57:41 -0000 X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 17 Oct 2011 16:57:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 99B282BB18D; Mon, 17 Oct 2011 12:57:27 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id RCq-o+TlV778; Mon, 17 Oct 2011 12:57:27 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6727B2BB168; Mon, 17 Oct 2011 12:57:27 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 8CB11145615; Mon, 17 Oct 2011 12:57:24 -0400 (EDT) Date: Mon, 17 Oct 2011 17:01:00 -0000 From: Joel Brobecker To: Mike Frysinger Cc: gdb-patches@sourceware.org, toolchain-devel@blackfin.uclinux.org Subject: Re: [PATCH] sim: use AC_REQUIRE with AC_PROG_CC Message-ID: <20111017165724.GC17942@adacore.com> References: <1310418640-32168-1-git-send-email-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1310418640-32168-1-git-send-email-vapier@gentoo.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00474.txt.bz2 > 2011-07-11 Mike Frysinger > > * aclocal.m4 (SIM_AC_COMMON): Call AC_REQUIRE on AC_PROG_CC. > Delete direct call to AC_PROG_CC. Looks, OK, except why did you move the call up? Looking at the autoconf documentation, AC_CONFIG_HEADER does not need to be called right after AC_INIT, it is only customary. So if there is a reason for us to change the location of the use of AC_PROG_CC, we probably want to fix the comment as well. > --- > sim/common/aclocal.m4 | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/sim/common/aclocal.m4 b/sim/common/aclocal.m4 > index 264cced..3ed5efd 100644 > --- a/sim/common/aclocal.m4 > +++ b/sim/common/aclocal.m4 > @@ -24,11 +24,11 @@ sinclude([../../config/zlib.m4]) > > AC_DEFUN([SIM_AC_COMMON], > [ > +AC_REQUIRE([AC_PROG_CC]) > # autoconf.info says this should be called right after AC_INIT. > AC_CONFIG_HEADER(ifelse([$1],,config.h,[$1]):config.in) > AC_CANONICAL_SYSTEM > AC_ARG_PROGRAM > -AC_PROG_CC > AC_PROG_INSTALL > > # Put a plausible default for CC_FOR_BUILD in Makefile. > -- > 1.7.6 -- Joel