From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Fix condition (Re: [patch] Verify byte-by-byte if both files are the same on "remote:")
Date: Tue, 11 Oct 2011 20:06:00 -0000 [thread overview]
Message-ID: <20111011200633.GA12794@host1.jankratochvil.net> (raw)
In-Reply-To: <201110111906.p9BJ6h8k023538@d06av02.portsmouth.uk.ibm.com>
On Tue, 11 Oct 2011 21:06:43 +0200, Ulrich Weigand wrote:
> I just noticed that this still causes spurious warnings since the
> condition is incorrect: we want to skip the warning if the parent's
> CRC matches the (potential) debuginfo *file* CRC, not the CRC the
> debuginfo is supposed to have.
I agree, sorry, I admit I did not try to test it, I should have asked for
a test.
Thanks,
Jan
prev parent reply other threads:[~2011-10-11 20:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 13:53 [rfc] False separate debuginfo warning with "remote:" access Ulrich Weigand
2011-10-10 8:38 ` [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remote:" access] Jan Kratochvil
2011-10-10 8:49 ` Jan Kratochvil
2011-10-10 13:48 ` [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remote:" Ulrich Weigand
2011-10-10 20:22 ` Jan Kratochvil
2011-10-10 21:23 ` [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remot Ulrich Weigand
2011-10-11 12:58 ` Jan Kratochvil
2011-10-11 19:07 ` [commit] Fix condition (Re: [patch] Verify byte-by-byte if both files are the same on "remote:") Ulrich Weigand
2011-10-11 20:06 ` Jan Kratochvil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011200633.GA12794@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox