From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Ulrich Weigand <uweigand@de.ibm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remot
Date: Tue, 11 Oct 2011 12:58:00 -0000 [thread overview]
Message-ID: <20111011125822.GA13269@host1.jankratochvil.net> (raw)
In-Reply-To: <201110102123.p9ALNSjr021999@d06av02.portsmouth.uk.ibm.com>
On Mon, 10 Oct 2011 23:23:28 +0200, Ulrich Weigand wrote:
> Jan Kratochvil wrote:
> > gdb/
> > 2011-10-10 Jan Kratochvil <jan.kratochvil@redhat.com>
> >
> > Fix separate debuginfo warning with "remote:" access.
> > * objfiles.h (struct objfile): New fields crc32 and crc32_p.
> > * symfile.c (get_file_crc): New function with the code moved from ...
> > (separate_debug_file_exists): ... this function, specifically variables
> > buffer and count. New variable verified_as_different, set it. Remove
> > file_crc initialization. Verify also if both files are not the same
> > manually, if needed.
>
> Looks good to me.
Checked in:
http://sourceware.org/ml/gdb-cvs/2011-10/msg00085.html
Thanks,
Jan
next prev parent reply other threads:[~2011-10-11 12:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-07 13:53 [rfc] False separate debuginfo warning with "remote:" access Ulrich Weigand
2011-10-10 8:38 ` [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remote:" access] Jan Kratochvil
2011-10-10 8:49 ` Jan Kratochvil
2011-10-10 13:48 ` [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remote:" Ulrich Weigand
2011-10-10 20:22 ` Jan Kratochvil
2011-10-10 21:23 ` [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remot Ulrich Weigand
2011-10-11 12:58 ` Jan Kratochvil [this message]
2011-10-11 19:07 ` [commit] Fix condition (Re: [patch] Verify byte-by-byte if both files are the same on "remote:") Ulrich Weigand
2011-10-11 20:06 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111011125822.GA13269@host1.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox