From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8255 invoked by alias); 11 Oct 2011 12:58:48 -0000 Received: (qmail 8245 invoked by uid 22791); 11 Oct 2011 12:58:47 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Oct 2011 12:58:28 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9BCwQE8023199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 11 Oct 2011 08:58:26 -0400 Received: from host1.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p9BCwOcI027022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2011 08:58:25 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9BCwNkO016525; Tue, 11 Oct 2011 14:58:23 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9BCwMHI016524; Tue, 11 Oct 2011 14:58:22 +0200 Date: Tue, 11 Oct 2011 12:58:00 -0000 From: Jan Kratochvil To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [patch] Verify byte-by-byte if both files are the same on "remote:" [Re: [rfc] False separate debuginfo warning with "remot Message-ID: <20111011125822.GA13269@host1.jankratochvil.net> References: <20111010202141.GA27651@host1.jankratochvil.net> <201110102123.p9ALNSjr021999@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110102123.p9ALNSjr021999@d06av02.portsmouth.uk.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00303.txt.bz2 On Mon, 10 Oct 2011 23:23:28 +0200, Ulrich Weigand wrote: > Jan Kratochvil wrote: > > gdb/ > > 2011-10-10 Jan Kratochvil > > > > Fix separate debuginfo warning with "remote:" access. > > * objfiles.h (struct objfile): New fields crc32 and crc32_p. > > * symfile.c (get_file_crc): New function with the code moved from ... > > (separate_debug_file_exists): ... this function, specifically variables > > buffer and count. New variable verified_as_different, set it. Remove > > file_crc initialization. Verify also if both files are not the same > > manually, if needed. > > Looks good to me. Checked in: http://sourceware.org/ml/gdb-cvs/2011-10/msg00085.html Thanks, Jan