From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31303 invoked by alias); 11 Oct 2011 20:06:55 -0000 Received: (qmail 31295 invoked by uid 22791); 11 Oct 2011 20:06:53 -0000 X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 11 Oct 2011 20:06:39 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9BK6bQx026899 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 11 Oct 2011 16:06:37 -0400 Received: from host1.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9BK6ZrU019496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 11 Oct 2011 16:06:36 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9BK6YwA012863; Tue, 11 Oct 2011 22:06:34 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9BK6XcC012862; Tue, 11 Oct 2011 22:06:33 +0200 Date: Tue, 11 Oct 2011 20:06:00 -0000 From: Jan Kratochvil To: Ulrich Weigand Cc: gdb-patches@sourceware.org Subject: Re: [commit] Fix condition (Re: [patch] Verify byte-by-byte if both files are the same on "remote:") Message-ID: <20111011200633.GA12794@host1.jankratochvil.net> References: <20111010202141.GA27651@host1.jankratochvil.net> <201110111906.p9BJ6h8k023538@d06av02.portsmouth.uk.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201110111906.p9BJ6h8k023538@d06av02.portsmouth.uk.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00332.txt.bz2 On Tue, 11 Oct 2011 21:06:43 +0200, Ulrich Weigand wrote: > I just noticed that this still causes spurious warnings since the > condition is incorrect: we want to skip the warning if the parent's > CRC matches the (potential) debuginfo *file* CRC, not the CRC the > debuginfo is supposed to have. I agree, sorry, I admit I did not try to test it, I should have asked for a test. Thanks, Jan